Add nullability to Identity / Identity.UI (#40167)

Contributes to #5680

Author: pranavkm

src/Identity/Core/src/DataProtectorTokenProvider.cs

@@ -89,7 +89,7 @@ public virtual async Task<string> GenerateAsync(string purpose, UserManager<TUse
             writer.Write(DateTimeOffset.UtcNow);
             writer.Write(userId);
             writer.Write(purpose ?? "");
-            string stamp = null;
+            string? stamp = null;
             if (manager.SupportsUserSecurityStamp)
             {
                 stamp = await manager.GetSecurityStampAsync(user);

src/Identity/Core/src/ExternalLoginInfo.cs

@@ -33,10 +33,10 @@ public ExternalLoginInfo(ClaimsPrincipal principal, string loginProvider, string
     /// <summary>
     /// The <see cref="AuthenticationToken"/>s associated with this login.
     /// </summary>
-    public IEnumerable<AuthenticationToken> AuthenticationTokens { get; set; }
+    public IEnumerable<AuthenticationToken>? AuthenticationTokens { get; set; }
 
     /// <summary>
     /// The <see cref="Authentication.AuthenticationProperties"/> associated with this login.
     /// </summary>
-    public AuthenticationProperties AuthenticationProperties { get; set; }
+    public AuthenticationProperties? AuthenticationProperties { get; set; }
 }

src/Identity/Core/src/IdentityCookiesBuilder.cs

@@ -14,20 +14,20 @@ public class IdentityCookiesBuilder
     /// <summary>
     /// Used to configure the application cookie.
     /// </summary>
-    public OptionsBuilder<CookieAuthenticationOptions> ApplicationCookie { get; set; }
+    public OptionsBuilder<CookieAuthenticationOptions>? ApplicationCookie { get; set; }
 
     /// <summary>
     /// Used to configure the external cookie.
     /// </summary>
-    public OptionsBuilder<CookieAuthenticationOptions> ExternalCookie { get; set; }
+    public OptionsBuilder<CookieAuthenticationOptions>? ExternalCookie { get; set; }
 
     /// <summary>
     /// Used to configure the two factor remember me cookie.
     /// </summary>
-    public OptionsBuilder<CookieAuthenticationOptions> TwoFactorRememberMeCookie { get; set; }
+    public OptionsBuilder<CookieAuthenticationOptions>? TwoFactorRememberMeCookie { get; set; }
 
     /// <summary>
     /// Used to configure the two factor user id cookie.
     /// </summary>
-    public OptionsBuilder<CookieAuthenticationOptions> TwoFactorUserIdCookie { get; set; }
+    public OptionsBuilder<CookieAuthenticationOptions>? TwoFactorUserIdCookie { get; set; }
 }

src/Identity/Core/src/IdentityServiceCollectionExtensions.cs

@@ -24,7 +24,7 @@ public static IdentityBuilder AddIdentity<TUser, TRole>(
         this IServiceCollection services)
         where TUser : class
         where TRole : class
-        => services.AddIdentity<TUser, TRole>(setupAction: null);
+        => services.AddIdentity<TUser, TRole>(setupAction: null!);
 
     /// <summary>
     /// Adds and configures the identity system for the specified User and Role types.

src/Identity/Core/src/LoggingExtensions.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#nullable disable
+
 namespace Microsoft.Extensions.Logging;
 
 internal static class LoggingExtensions

src/Identity/Core/src/Microsoft.AspNetCore.Identity.csproj

@@ -7,7 +7,6 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;identity;membership</PackageTags>
     <IsPackable>false</IsPackable>
-    <Nullable>disable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/Identity/Core/src/PublicAPI.Unshipped.txt

@@ -13,10 +13,10 @@ public class SecurityStampRefreshingPrincipalContext
     /// <summary>
     /// The principal contained in the current cookie.
     /// </summary>
-    public ClaimsPrincipal CurrentPrincipal { get; set; }
+    public ClaimsPrincipal? CurrentPrincipal { get; set; }
 
     /// <summary>
     /// The new principal which should replace the current.
     /// </summary>
-    public ClaimsPrincipal NewPrincipal { get; set; }
+    public ClaimsPrincipal? NewPrincipal { get; set; }
 }

src/Identity/Core/src/SecurityStampRefreshingPrincipalContext.cs

@@ -36,7 +36,7 @@ public SecurityStampValidator(IOptions<SecurityStampValidatorOptions> options, S
         SignInManager = signInManager;
         Options = options.Value;
         Clock = clock;
-        Logger = logger.CreateLogger(this.GetType().FullName);
+        Logger = logger.CreateLogger(GetType());
     }
 
     /// <summary>
@@ -102,7 +102,7 @@ protected virtual async Task SecurityStampVerified(TUser user, CookieValidatePri
     /// </summary>
     /// <param name="principal">The principal to verify.</param>
     /// <returns>The verified user or null if verification fails.</returns>
-    protected virtual Task<TUser> VerifySecurityStamp(ClaimsPrincipal principal)
+    protected virtual Task<TUser?> VerifySecurityStamp(ClaimsPrincipal? principal)
         => SignInManager.ValidateSecurityStampAsync(principal);
 
     /// <summary>

src/Identity/Core/src/SecurityStampValidator.cs

@@ -19,5 +19,5 @@ public class SecurityStampValidatorOptions
     /// <summary>
     /// Invoked when the default security stamp validator replaces the user's ClaimsPrincipal in the cookie.
     /// </summary>
-    public Func<SecurityStampRefreshingPrincipalContext, Task> OnRefreshingPrincipal { get; set; }
+    public Func<SecurityStampRefreshingPrincipalContext, Task>? OnRefreshingPrincipal { get; set; }
 }