Skip to content

Fix browser cookie tests to only run with HTTPS #39665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix browser cookie tests to only run with HTTPS #39665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad3d4c1
Fix browser cookie tests to only run with HTTPS
BrennanConroy Jan 20, 2022
c00430a
fb
BrennanConroy Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/SignalR/clients/ts/FunctionalTests/EchoConnectionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,13 @@

using System.Buffers;
using Microsoft.AspNetCore.Connections;
using Microsoft.AspNetCore.Http.Connections;

namespace FunctionalTests;

public class EchoConnectionHandler : ConnectionHandler
{
public override async Task OnConnectedAsync(ConnectionContext connection)
{
var context = connection.GetHttpContext();
// The 'withCredentials' tests wont send a cookie for cross-site requests
if (!context.WebSockets.IsWebSocketRequest && !context.Request.Cookies.ContainsKey("testCookie"))
{
return;
}

while (true)
{
var result = await connection.Transport.Input.ReadAsync();
Expand Down
2 changes: 2 additions & 0 deletions src/SignalR/clients/ts/FunctionalTests/ts/ConnectionTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ describe("connection", () => {

await connection.start(TransferFormat.Text);

await connection.stop();

await closePromise;
});
}
Expand Down
Loading