Fix browser cookie tests to only run with HTTPS #39665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Jan 20, 2022
Member
|
Force merging per teams discussion |
ghost
added this to the
BrennanConroy
added a commit
that referenced
this pull request
Jan 21, 2022
BrennanConroy
added a commit
that referenced
this pull request
Jan 21, 2022
BrennanConroy
added a commit
that referenced
this pull request
Jan 21, 2022
This was referenced Jan 21, 2022
ShreyasJejurkar
pushed a commit
to ShreyasJejurkar/aspnetcore
that referenced
this pull request
Jan 22, 2022
dougbu
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Fix browser cookie tests to only run with HTTPS (#39665) * fixup
wtgodbe
pushed a commit
to vseanreesermsft/aspnetcore
that referenced
this pull request
Feb 1, 2022
dougbu
pushed a commit
to vseanreesermsft/aspnetcore
that referenced
this pull request
Feb 2, 2022
wtgodbe
added a commit
that referenced
this pull request
Feb 2, 2022
* Fix browser cookie tests to only run with HTTPS (#39665) * fixup * fixup * Skip tests with expired cert * Fxiup * Fixup * Improve File access issues * Remove BasicTestApp Change Co-authored-by: Brennan <[email protected]> Co-authored-by: Hao Kung <[email protected]>
wtgodbe
added a commit
that referenced
this pull request
Feb 2, 2022
) * Fix browser cookie tests to only run with HTTPS (#39665) * fixup * Skip failing cert tests for now * Fix spacing * Resolve conflicts Co-authored-by: Brennan <[email protected]> Co-authored-by: Hao Kung <[email protected]> Co-authored-by: Doug Bunting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 96 was released a few days ago and our Mac machines just updated to the new version. This version sets
SameSiteto lax for cookies if they don't specify any, which breaks some browser tests in SignalR.The main fix is in EchoConnectionHandler.cs, ConnectionTests.ts, and line 613 of HubConnectionTests.ts where we now gate the cookie test on using an HTTPS connection.
The rest of the changes are to fix some warnings about using
done()with anasyncittest method which is deprecated.