Skip to content

Add MIT License Headers to Components/Web.JS/**/*.ts Files #39164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2022
Merged

Add MIT License Headers to Components/Web.JS/**/*.ts Files #39164

merged 2 commits into from
Jan 3, 2022

Conversation

@TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Dec 23, 2021

Tagging @dotnet/aspnet-build / @Pilchie due to the license header related changes.

@TanayParikh TanayParikh requested review from a team and Pilchie December 23, 2021 04:32
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Dec 23, 2021
@TanayParikh TanayParikh mentioned this pull request Dec 23, 2021
Merged
@pranavkm
Copy link
Contributor

pranavkm commented Dec 23, 2021

This one definitely feels like it'll stomp over the other refactoring PR. Should we hold off on changes to Components until that is sorted?

@TanayParikh TanayParikh self-assigned this Jan 3, 2022
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Jan 3, 2022 •
edited
Loading

stomp over the other refactoring PR

Are you referring to #38721? If so, given these are just license header changes, I'd prefer to get it in so this can be closed out. I don't mind going back to #38721 and fixing any merge conflicts if they appear as a result of this PR.

@pranavkm
Copy link
Contributor

pranavkm commented Jan 3, 2022

Ok. FYI @pavelsavara since this would cause some minor grievances to your ongoing PR.

@TanayParikh TanayParikh merged commit 231cc28 into main Jan 3, 2022
@TanayParikh TanayParikh deleted the taparik/webjsLicenseHeader branch January 3, 2022 19:10
@ghost ghost added this to the 7.0-preview1 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TanayParikh TanayParikh

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@TanayParikh @pranavkm @wtgodbe