Migrate JSInterop to ESLint #39162
Merged
Migrate JSInterop to ESLint #39162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
requested review from
a team,
Pilchie and
captainsafia
as code owners
TanayParikh
commented
Dec 23, 2021
src/JSInterop/Microsoft.JSInterop.JS/src/src/Microsoft.JSInterop.ts
Outdated
Show resolved
Hide resolved
TanayParikh
commented
Dec 23, 2021
| let result: any = this._jsObject; | ||
| let lastSegmentValue: any; | ||
|
|
||
| identifier.split('.').forEach(segment => { |
Contributor
Author
There was a problem hiding this comment.
Note; reviewing this file with ?w=1 may be easier given indentation / formatting changes.
Contributor
|
Does this affect #38721 in any way? |
Contributor
Author
Nope, should be entirely separate. |
pranavkm
reviewed
Dec 23, 2021
src/JSInterop/Microsoft.JSInterop.JS/src/src/Microsoft.JSInterop.ts
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop.JS/src/src/Microsoft.JSInterop.ts
Outdated
Show resolved
Hide resolved
pranavkm
approved these changes
Dec 23, 2021
TanayParikh
commented
Jan 3, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSLint has been deprecated in favor of ESLint. We only use TSLint in
JSInteropwithindotnet/aspnetcore(we've migrated elsewhere already). With this PR we should be fully off of TSLint 🎉