Migrate JSInterop to ESLint

.devcontainer/devcontainer.json

@@ -20,7 +20,8 @@
   "extensions": [
     "ms-dotnettools.csharp",
     "EditorConfig.EditorConfig",
-    "k--kato.docomment"
+    "k--kato.docomment",
+    "dbaeumer.vscode-eslint"
   ],
   "settings": {
     // Loading projects on demand is better for larger codebases

src/JSInterop/Microsoft.JSInterop.JS/src/.eslintrc.json

@@ -0,0 +1,244 @@
+{
+  "env": {
+    "browser": true,
+    "es2021": true
+  },
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": 12,
+    "sourceType": "module"
+  },
+  "plugins": [
+    "@typescript-eslint"
+  ],
+  "rules": {
+    "accessor-pairs": "error",
+    "array-bracket-newline": "error",
+    "array-bracket-spacing": "error",
+    "array-callback-return": "error",
+    "array-element-newline": "error",
+    "arrow-spacing": "error",
+    "block-scoped-var": "error",
+    "block-spacing": "error",
+    "brace-style": "error",
+    "camelcase": "error",
+    "class-methods-use-this": "error",
+    "comma-dangle": "error",
+    "comma-spacing": "error",
+    "comma-style": "error",
+    "complexity": "error",
+    "computed-property-spacing": "error",
+    "consistent-return": "error",
+    "consistent-this": "error",
+    "curly": "error",
+    "default-case": "error",
+    "default-case-last": "error",
+    "default-param-last": "error",
+    "dot-location": "error",
+    "dot-notation": "error",
+    "eol-last": "error",
+    "eqeqeq": "error",
+    "func-call-spacing": "error",
+    "func-name-matching": "error",
+    "func-names": "error",
+    "function-paren-newline": "error",
+    "generator-star-spacing": "error",
+    "grouped-accessor-pairs": "error",
+    "guard-for-in": "error",
+    "id-denylist": "error",
+    "id-length": "error",
+    "id-match": "error",
+    "implicit-arrow-linebreak": "error",
+    "indent": "error",
+    "jsx-quotes": "error",
+    "key-spacing": "error",
+    "keyword-spacing": "error",
+    "linebreak-style": "error",
+    "lines-between-class-members": "error",
+    "max-classes-per-file": "off",
+    "max-depth": "error",
+    "max-len": [
+      "error",
+      {
+        "code": 300
+      }
+    ],
+    "max-lines": "off",
+    "max-lines-per-function": "error",
+    "max-nested-callbacks": "error",
+    "max-statements-per-line": "error",
+    "multiline-comment-style": [
+      "warn",
+      "separate-lines"
+    ],
+    "new-cap": "error",
+    "new-parens": "error",
+    "newline-per-chained-call": "error",
+    "no-alert": "error",
+    "no-array-constructor": "error",
+    "no-await-in-loop": "error",
+    "no-bitwise": "off",
+    "no-caller": "error",
+    "no-confusing-arrow": "error",
+    "no-console": "off",
+    "no-constructor-return": "error",
+    "no-continue": "error",
+    "no-div-regex": "error",
+    "no-duplicate-imports": "error",
+    "no-else-return": "error",
+    "no-empty-function": "error",
+    "no-eq-null": "error",
+    "no-eval": "error",
+    "no-extend-native": "error",
+    "no-extra-bind": "error",
+    "no-extra-label": "error",
+    "no-floating-decimal": "error",
+    "no-implicit-coercion": "error",
+    "no-implicit-globals": "error",
+    "no-implied-eval": "error",
+    "no-invalid-this": "error",
+    "no-iterator": "error",
+    "no-label-var": "error",
+    "no-labels": "error",
+    "no-lone-blocks": "error",
+    "no-lonely-if": "error",
+    "no-loop-func": "error",
+    "no-mixed-operators": "error",
+    "no-multi-assign": "error",
+    "no-multi-spaces": "error",
+    "no-multi-str": "error",
+    "no-multiple-empty-lines": "error",
+    "no-namespace": "off",
+    "no-negated-condition": "error",
+    "no-nested-ternary": "error",
+    "no-new": "error",
+    "no-new-func": "error",
+    "no-new-object": "error",
+    "no-new-wrappers": "error",
+    "no-octal-escape": "error",
+    "no-promise-executor-return": "error",
+    "no-proto": "error",
+    "no-restricted-exports": "error",
+    "no-restricted-globals": "error",
+    "no-restricted-imports": "error",
+    "no-restricted-properties": "error",
+    "no-restricted-syntax": "error",
+    "no-return-assign": "error",
+    "no-return-await": "error",
+    "no-script-url": "error",
+    "no-self-compare": "error",
+    "no-sequences": "error",
+    "no-shadow": "error",
+    "no-tabs": "error",
+    "no-template-curly-in-string": "error",
+    "no-throw-literal": "error",
+    "no-trailing-spaces": "error",
+    "no-undef-init": "error",
+    "no-unmodified-loop-condition": "error",
+    "no-unneeded-ternary": "error",
+    "no-unreachable-loop": "error",
+    "no-unused-expressions": "error",
+    "no-unused-private-class-members": "error",
+    "no-useless-call": "error",
+    "no-useless-computed-key": "error",
+    "no-useless-concat": "error",
+    "no-useless-rename": "error",
+    "no-useless-return": "error",
+    "no-var": "error",
+    "no-void": "error",
+    "no-warning-comments": "error",
+    "no-whitespace-before-property": "error",
+    "nonblock-statement-body-position": "error",
+    "object-curly-newline": "error",
+    "object-shorthand": "error",
+    "one-var-declaration-per-line": "error",
+    "operator-assignment": "error",
+    "operator-linebreak": "error",
+    "padding-line-between-statements": "error",
+    "prefer-const": "error",
+    "prefer-destructuring": "error",
+    "prefer-exponentiation-operator": "error",
+    "prefer-named-capture-group": "error",
+    "prefer-numeric-literals": "error",
+    "prefer-object-has-own": "error",
+    "prefer-object-spread": "error",
+    "prefer-promise-reject-errors": "error",
+    "prefer-regex-literals": "error",
+    "prefer-rest-params": "error",
+    "prefer-template": "error",
+    "quotes": "error",
+    "radix": "error",
+    "require-atomic-updates": "error",
+    "require-await": "error",
+    "require-unicode-regexp": "error",
+    "rest-spread-spacing": "error",
+    "semi": "error",
+    "semi-spacing": "error",
+    "semi-style": "error",
+    "sort-imports": "error",
+    "sort-vars": "error",
+    "space-before-blocks": "error",
+    "space-in-parens": "error",
+    "space-infix-ops": "error",
+    "space-unary-ops": "error",
+    "spaced-comment": "error",
+    "strict": "error",
+    "switch-colon-spacing": "error",
+    "symbol-description": "error",
+    "template-curly-spacing": "error",
+    "template-tag-spacing": "error",
+    "unicode-bom": "error",
+    "vars-on-top": "error",
+    "wrap-iife": "error",
+    "wrap-regex": "error",
+    "yield-star-spacing": "error",
+    "yoda": "error",
+    "prefer-spread": "warn",
+    "object-property-newline": "off",
+    "no-useless-constructor": "off",
+    "prefer-arrow-callback": "off",
+    "object-curly-spacing": "off",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "arrow-body-style": "off",
+    "no-plusplus": "off",
+    "no-undefined": "off",
+    "quote-props": "off",
+    "sort-keys": "off",
+    "lines-around-comment": "off",
+    "no-prototype-builtins": "off",
+    "multiline-ternary": "off",
+    "no-ternary": "off",
+    "no-inner-declarations": "off",
+    "max-params": "off",
+    "no-param-reassign": "off",
+    "no-magic-numbers": "off",
+    "func-style": "off",
+    "capitalized-comments": "off",
+    "no-use-before-define": "off",
+    "space-before-function-paren": "off",
+    "init-declarations": "off",
+    "arrow-parens": "off",
+    "function-call-argument-newline": "off",
+    "no-underscore-dangle": "off",
+    "max-statements": "off",
+    "padded-blocks": "off",
+    "one-var": "off",
+    "no-extra-parens": "off",
+    "no-inline-comments": "off",
+    "line-comment-position": "off",
+    "@typescript-eslint/no-namespace": "off",
+    "@typescript-eslint/prefer-namespace-keyword": "off",
+    "@typescript-eslint/ban-types": [
+      "error",
+      {
+        "types": {
+          "Function": false
+        }
+      }
+    ]
+  }
+}

src/JSInterop/Microsoft.JSInterop.JS/src/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/dotnet-js-interop",
-  "version": "5.0.0-dev",
+  "version": "7.0.0-dev",
   "description": "Provides abstractions and features for interop between .NET and JavaScript code.",
   "main": "dist/Microsoft.JSInterop.js",
   "types": "dist/Microsoft.JSInterop.d.ts",
@@ -9,7 +9,7 @@
     "preclean": "yarn install --mutex network --frozen-lockfile",
     "clean": "node node_modules/rimraf/bin.js ./dist",
     "build": "npm run clean && npm run build:esm",
-    "build:lint": "node node_modules/tslint/bin/tslint -p ./tsconfig.json",
+    "build:lint": "eslint -c .eslintrc.json --ext .ts ./src",
     "build:esm": "node node_modules/typescript/bin/tsc --project ./tsconfig.json"
   },
   "repository": {
@@ -26,8 +26,12 @@
     "dist/**"
   ],
   "devDependencies": {
+    "@typescript-eslint/eslint-plugin": "^5.8.0",
+    "@typescript-eslint/parser": "^5.8.0",
+    "eslint": "^8.5.0",
+    "eslint-plugin-jsdoc": "^37.4.0",
+    "eslint-plugin-prefer-arrow": "^1.2.3",
     "rimraf": "^3.0.2",
-    "tslint": "^6.1.3",
     "typescript": "^4.2.2"
   }
 }