[Backport] [Java] Safely call onError on Subjects (#31779) #32026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
BrennanConroy
force-pushed
the
brecon/bponerror
branch
from
ce6ed5b to
8611bb8
Compare
halter73
approved these changes
Apr 22, 2021
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31779
Description
If a connection is being started up and it receives the handshake response at the same time that the handshake timeout occurs the app can crash.
Customer Impact
App can crash during connection setup due to a race condition with the connection handshake.
Regression?
Risk
Small change that shouldn't affect any thing except for fixing a race.
Verification
Packaging changes reviewed?
Addresses #31491