[Java] Safely call onError on Subjects #31779
Conversation
BrennanConroy
added
area-signalr
|
|
||
| public void timeoutHandshakeResponse(long timeout, TimeUnit unit) { | ||
| handshakeTimeout = Executors.newSingleThreadScheduledExecutor(); | ||
| handshakeTimeout.schedule(() -> { |
There was a problem hiding this comment.
I'm curious why this uses an executor to implement the timeout instead of using RxJava's timeout operator?
connectionState.transport.send(handshake).timeout(..., ...)
There was a problem hiding this comment.
Probably implemented before RxJava was used.
Keeping it as-is so it's easier to backport to 5.0
| private void errorHandshake(Exception error) { | ||
| lock.lock(); | ||
| try { | ||
| // If onError is called on a completed subject the global error handler is called |
There was a problem hiding this comment.
Is there a way we could hook the global error handler with our tests and fail if it ever gets called? Would that have been able to catch this?
There was a problem hiding this comment.
you could use something like this:
https://github.com/uber/AutoDispose/blob/2.0.0/test-utils/src/main/java/autodispose2/test/RxErrorsRule.java
There was a problem hiding this comment.
Thanks for the pointer, adapted something similar for junit 5
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HubConnection.java
Outdated
Show resolved
Hide resolved
Fixes #31491
We should backport this to 5.0.