Default the timezone to UTC if it is not resolved. #27505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
captainsafia
approved these changes
Nov 3, 2020
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
SteveSandersonMS
approved these changes
Nov 6, 2020
enisn
approved these changes
Nov 9, 2020
leecow
added
Servicing-approved
Member
|
@pranavkm can you resolve the conflicts? |
Member
|
@mkArtakMSFT is there someone from @dotnet/aspnet-blazor-eng who can work on the conflicts here? |
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation, this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC when the timezone cannot be resolved. Fixes dotnet/runtime#44154 Port of #27444
pranavkm
force-pushed
the
prkrishn/undefined-tz
branch
from
89dd4b0 to
63b0568
Compare
Contributor
Author
|
🆙 📅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation,
this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC
when the timezone cannot be resolved.
Fixes dotnet/runtime#44154
Port of #27444
Customer impact
Blazor WASM applications may not start on some browsers that do not correctly resolve timezone information
Regression
No.
Risk
We default the app to using UTC timezone which makes it a fairly low risk change. This does not affect browsers / apps where timezones can be correctly resolved which is the majority of our users.