Set the timezone if it is undefined #27444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
approved these changes
Nov 2, 2020
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Thanks @lewing. @mkArtakMSFT we should consider patching this in 5.0.1
|
Hello @pranavkm! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 22 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
pranavkm
added a commit
that referenced
this pull request
Nov 3, 2020
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation, this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC when the timezone cannot be resolved. Fixes dotnet/runtime#44154 Port of #27444
pranavkm
added a commit
that referenced
this pull request
Nov 19, 2020
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation, this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC when the timezone cannot be resolved. Fixes dotnet/runtime#44154 Port of #27444
mkArtakMSFT
added a commit
that referenced
this pull request
Nov 21, 2020
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation, this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC when the timezone cannot be resolved. Fixes dotnet/runtime#44154 Port of #27444 Co-authored-by: Artak <[email protected]>
3dots
pushed a commit
to 3dots/aspnetcore-Web.JS
that referenced
this pull request
Feb 19, 2024
Browsers may not correctly resolve the machine's timezone in some cases. In the current implementation, this results in an exception being thrown by .NET Core (WASM). This code defaults the timezone to UTC when the timezone cannot be resolved. Fixes dotnet/runtime#44154 Port of dotnet/aspnetcore#27444 Co-authored-by: Artak <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timezone isn't set in the host set it to UTC
Addresses dotnet/runtime#44154