Blazor flaky test sanctuary #26286
Merged
Blazor flaky test sanctuary #26286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Sep 24, 2020
Member
Author
|
Note: there was a big spike of test failures on 8/27 which all of these tests failed, none of these tests have failed in the last 30 days in the quarantined-pr pipeline excluding that one build |
This was
linked to
issues
Sep 28, 2020
javiercn
approved these changes
Sep 29, 2020
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable a bunch of tests that seem to be behaving well (all have passed 100% in last 30 days on aspnetcore-quarantined-pr https://dev.azure.com/dnceng/public/_test/analytics?definitionId=869&contextType=build 172/172
Also turn off implicit waiting and explicitly call quit for selenium cleanup, as per:
https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait
https://www.selenium.dev/documentation/en/webdriver/browser_manipulation/#quitting-the-browser-at-the-end-of-a-session