File tree Expand file tree Collapse file tree 8 files changed +4
-12
lines changed Expand file tree Collapse file tree 8 files changed +4
-12
lines changed Original file line number Diff line number Diff line change @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
3434 Browser . Exists ( By . Id ( "culture-selector" ) ) ;
3535 }
3636
37- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/24692" ) ]
3837 [ Theory ]
3938 [ InlineData ( "en-US" ) ]
4039 [ InlineData ( "fr-FR" ) ]
Original file line number Diff line number Diff line change @@ -389,7 +389,6 @@ public void CanBindTextboxShort()
389389 }
390390
391391 [ Fact ]
392- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23826" ) ]
393392 public void CanBindTextboxNullableShort ( )
394393 {
395394 var target = Browser . FindElement ( By . Id ( "textbox-nullable-short" ) ) ;
@@ -512,7 +511,6 @@ public void CanBindTextboxDouble()
512511 }
513512
514513 [ Fact ]
515- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23596" ) ]
516514 public void CanBindTextboxNullableDouble ( )
517515 {
518516 var target = Browser . FindElement ( By . Id ( "textbox-nullable-double" ) ) ;
@@ -612,7 +610,6 @@ public void CanBindTextboxNullableDecimal()
612610 // This tests what happens you put invalid (unconvertable) input in. This is separate from the
613611 // other tests because it requires type="text" - the other tests use type="number"
614612 [ Fact ]
615- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/24756" ) ]
616613 public void CanBindTextbox_Decimal_InvalidInput ( )
617614 {
618615 var target = Browser . FindElement ( By . Id ( "textbox-decimal-invalid" ) ) ;
Original file line number Diff line number Diff line change @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
3434 }
3535
3636 [ Fact ]
37- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23643" ) ]
3837 public void ShowsErrorNotification_OnError_Dismiss ( )
3938 {
4039 var errorUi = Browser . FindElement ( By . Id ( "blazor-error-ui" ) ) ;
@@ -52,7 +51,6 @@ public void ShowsErrorNotification_OnError_Dismiss()
5251 }
5352
5453 [ Fact ]
55- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23596" ) ]
5654 public void ShowsErrorNotification_OnError_Reload ( )
5755 {
5856 var causeErrorButton = Browser . Exists ( By . Id ( "throw-simple-exception" ) ) ;
Original file line number Diff line number Diff line change @@ -30,7 +30,6 @@ protected override void InitializeAsyncCore()
3030 }
3131
3232 [ Theory ]
33- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23643" ) ]
3433 [ InlineData ( "capturing_lambda" ) ]
3534 [ InlineData ( "unbound_lambda" ) ]
3635 [ InlineData ( "unbound_lambda_nested" ) ]
Original file line number Diff line number Diff line change @@ -87,7 +87,6 @@ public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string
8787 // We need to do step 4 to make sure that the value we're entering can "stick" in the form field.
8888 // We can't use ".Text" because DOM reasons :(
8989 [ Theory ]
90- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/23643" ) ]
9190 [ InlineData ( "en-US" ) ]
9291 [ InlineData ( "fr-FR" ) ]
9392 public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields ( string culture )
Original file line number Diff line number Diff line change @@ -92,7 +92,6 @@ public void CanInsertUnkeyed()
9292 }
9393
9494 [ Fact ]
95- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/24190" ) ]
9695 public void CanDeleteUnkeyed ( )
9796 {
9897 PerformTest (
@@ -112,7 +111,6 @@ public void CanDeleteUnkeyed()
112111 }
113112
114113 [ Fact ]
115- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/24190" ) ]
116114 public void CanReorder ( )
117115 {
118116 PerformTest (
Original file line number Diff line number Diff line change @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
3434 }
3535
3636 [ Fact ]
37- [ QuarantinedTest ( "https://github.com/dotnet/aspnetcore/issues/25929" ) ]
3837 public void WebAssemblyConfiguration_Works ( )
3938 {
4039 // Verify values from the default 'appsettings.json' are read.
Original file line number Diff line number Diff line change @@ -70,6 +70,7 @@ public async Task DisposeAsync()
7070 var browsers = await Task . WhenAll ( _browsers . Values ) ;
7171 foreach ( var ( browser , log ) in browsers )
7272 {
73+ browser ? . Quit ( ) ;
7374 browser ? . Dispose ( ) ;
7475 }
7576
@@ -320,7 +321,9 @@ private string UserProfileDirectory(string context)
320321 capabilities ,
321322 TimeSpan . FromSeconds ( 60 ) . Add ( TimeSpan . FromSeconds ( attempt * 60 ) ) ) ;
322323
323- driver . Manage ( ) . Timeouts ( ) . ImplicitWait = TimeSpan . FromSeconds ( 1 ) ;
324+ // Make sure implicit waits are disabled as they don't mix well with explicit waiting
325+ // see https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait
326+ driver . Manage ( ) . Timeouts ( ) . ImplicitWait = TimeSpan . Zero ;
324327 var logs = new RemoteLogs ( driver ) ;
325328
326329 return ( driver , logs ) ;
You can’t perform that action at this time.
0 commit comments