Skip to content

Accessibility fixes #25678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Accessibility fixes #25678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35149c1
Fix header tab ordering issues. Fixes 1163117
SteveSandersonMS Sep 7, 2020
5ba5e8f
Ensure text can be zoomed to 200% without switching to mobile layout.…
SteveSandersonMS Sep 7, 2020
c243b2a
Ensure "Log out" link can show focus state. Fixes 1162890
SteveSandersonMS Sep 7, 2020
bed8eaa
Use screen reader-friendly link text. Fixes 1163642
SteveSandersonMS Sep 7, 2020
26b54db
Update template test
SteveSandersonMS Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Login.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
{
<div>
<p>
There are no external authentication services configured. See <a href="https://go.microsoft.com/fwlink/?LinkID=532715">this article</a>
for details on setting up this ASP.NET application to support logging in via external services.
There are no external authentication services configured. See this <a href="https://go.microsoft.com/fwlink/?LinkID=532715">article
about setting up this ASP.NET application to support logging in via external services</a>.
</p>
</div>
}
Expand Down
4 changes: 2 additions & 2 deletions src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Register.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
{
<div>
<p>
There are no external authentication services configured. See <a href="https://go.microsoft.com/fwlink/?LinkID=532715">this article</a>
for details on setting up this ASP.NET application to support logging in via external services.
There are no external authentication services configured. See this <a href="https://go.microsoft.com/fwlink/?LinkID=532715">article
about setting up this ASP.NET application to support logging in via external services</a>.
</p>
</div>
}
Expand Down
4 changes: 4 additions & 0 deletions src/Identity/UI/src/wwwroot/V4/css/site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ a {
border-color: #1861ac;
}

.btn-link.nav-link:focus {
outline: black auto 1px;
}

/* Sticky footer styles
-------------------------------------------------- */
html {
Expand Down
4 changes: 2 additions & 2 deletions ...Templates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/Shared/MainLayout.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
text-overflow: ellipsis;
}

@media (max-width: 767.98px) {
@media (max-width: 640.98px) {
.top-row:not(.auth) {
display: none;
}
Expand All @@ -45,7 +45,7 @@
}
}

@media (min-width: 768px) {
@media (min-width: 641px) {
.page {
flex-direction: row;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/Shared/NavMenu.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
color: white;
}

@media (min-width: 768px) {
@media (min-width: 641px) {
.navbar-toggler {
display: none;
}
Expand Down
4 changes: 2 additions & 2 deletions ....ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/Shared/MainLayout.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
text-overflow: ellipsis;
}

@media (max-width: 767.98px) {
@media (max-width: 640.98px) {
.top-row:not(.auth) {
display: none;
}
Expand All @@ -45,7 +45,7 @@
}
}

@media (min-width: 768px) {
@media (min-width: 641px) {
.page {
flex-direction: row;
}
Expand Down
2 changes: 1 addition & 1 deletion ...Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/Shared/NavMenu.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
color: white;
}

@media (min-width: 768px) {
@media (min-width: 641px) {
.navbar-toggler {
display: none;
}
Expand Down
12 changes: 6 additions & 6 deletions ...ctTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/Pages/Shared/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@
aria-expanded="false" aria-label="Toggle navigation">
<span class="navbar-toggler-icon"></span>
</button>
<div class="navbar-collapse collapse d-sm-inline-flex flex-sm-row-reverse">
@*#if (IndividualAuth || OrganizationalAuth)
<partial name="_LoginPartial" />
#elseif (WindowsAuth)
<p class="nav navbar-text navbar-right">Hello, @User.Identity.Name!</p>
#endif*@
<div class="navbar-collapse collapse d-sm-inline-flex justify-content-between">
<ul class="navbar-nav flex-grow-1">
<li class="nav-item">
<a class="nav-link text-dark" asp-area="" asp-page="/Index">Home</a>
Expand All @@ -30,6 +25,11 @@
<a class="nav-link text-dark" asp-area="" asp-page="/Privacy">Privacy</a>
</li>
</ul>
@*#if (IndividualAuth || OrganizationalAuth)
<partial name="_LoginPartial" />
#elseif (WindowsAuth)
<p class="nav navbar-text">Hello, @User.Identity.Name!</p>
#endif*@
</div>
</div>
</nav>
Expand Down
12 changes: 6 additions & 6 deletions ...ojectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/Views/Shared/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@
aria-expanded="false" aria-label="Toggle navigation">
<span class="navbar-toggler-icon"></span>
</button>
<div class="navbar-collapse collapse d-sm-inline-flex flex-sm-row-reverse">
@*#if (IndividualAuth || OrganizationalAuth)
<partial name="_LoginPartial" />
#elseif (WindowsAuth)
<p class="nav navbar-text navbar-right">Hello, @User.Identity.Name!</p>
#endif*@
<div class="navbar-collapse collapse d-sm-inline-flex justify-content-between">
<ul class="navbar-nav flex-grow-1">
<li class="nav-item">
<a class="nav-link text-dark" asp-area="" asp-controller="Home" asp-action="Index">Home</a>
Expand All @@ -30,6 +25,11 @@
<a class="nav-link text-dark" asp-area="" asp-controller="Home" asp-action="Privacy">Privacy</a>
</li>
</ul>
@*#if (IndividualAuth || OrganizationalAuth)
<partial name="_LoginPartial" />
#elseif (WindowsAuth)
<p class="nav navbar-text">Hello, @User.Identity.Name!</p>
#endif*@
</div>
</div>
</nav>
Expand Down
8 changes: 4 additions & 4 deletions ...rojectTemplates/content/Angular-CSharp/ClientApp/src/app/nav-menu/nav-menu.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,9 @@
<span class="navbar-toggler-icon"></span>
</button>
<div
class="navbar-collapse collapse d-sm-inline-flex flex-sm-row-reverse"
class="navbar-collapse collapse d-sm-inline-flex justify-content-end"
[ngClass]="{ show: isExpanded }"
>
<!--#if (IndividualLocalAuth) -->
<app-login-menu></app-login-menu>
<!--#endif -->
<ul class="navbar-nav flex-grow">
<li
class="nav-item"
Expand All @@ -41,6 +38,9 @@
>
</li>
</ul>
<!--#if (IndividualLocalAuth) -->
<app-login-menu></app-login-menu>
<!--#endif -->
</div>
</div>
</nav>
Expand Down
20 changes: 10 additions & 10 deletions src/ProjectTemplates/test/MvcTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ public async Task MvcTemplate_IndividualAuth(bool useLocalDB)
Url = PageUrls.ForgotPassword,
Links = new string [] {
PageUrls.HomeUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.HomeUrl,
PageUrls.PrivacyUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.PrivacyUrl
}
},
Expand All @@ -154,10 +154,10 @@ public async Task MvcTemplate_IndividualAuth(bool useLocalDB)
Url = PageUrls.HomeUrl,
Links = new string[] {
PageUrls.HomeUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.HomeUrl,
PageUrls.PrivacyUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.DocsUrl,
PageUrls.PrivacyUrl
}
Expand All @@ -167,10 +167,10 @@ public async Task MvcTemplate_IndividualAuth(bool useLocalDB)
Url = PageUrls.PrivacyFullUrl,
Links = new string[] {
PageUrls.HomeUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.HomeUrl,
PageUrls.PrivacyUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.PrivacyUrl
}
},
Expand All @@ -179,10 +179,10 @@ public async Task MvcTemplate_IndividualAuth(bool useLocalDB)
Url = PageUrls.LoginUrl,
Links = new string[] {
PageUrls.HomeUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.HomeUrl,
PageUrls.PrivacyUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.ForgotPassword,
PageUrls.RegisterUrl,
PageUrls.ResendEmailConfirmation,
Expand All @@ -194,10 +194,10 @@ public async Task MvcTemplate_IndividualAuth(bool useLocalDB)
Url = PageUrls.RegisterUrl,
Links = new string [] {
PageUrls.HomeUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.HomeUrl,
PageUrls.PrivacyUrl,
PageUrls.RegisterUrl,
PageUrls.LoginUrl,
PageUrls.ExternalArticle,
PageUrls.PrivacyUrl
}
Expand Down