Accessibility fixes #25678
Merged
Accessibility fixes #25678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See individual commit messages for details about what each change fixes. |
12 tasks
Member
|
LGTM, some of these fixes are applicable to other templates I imagine, isn't that the case? (Like the navmenu one). I'm not asking you to do anything, just checking in case we need a separate bug to deal with them. |
javiercn
approved these changes
Sep 7, 2020
Member
Author
|
The navmenu fix only applies in the cases I’ve applied it, as far as I see. |
SteveSandersonMS
force-pushed
the
stevesa/accessibility-fixes
branch
from
4fa30f5 to
bed8eaa
Compare
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Contributor
|
@Pilchie can we get this approved for RC2? Thanks! |
mkArtakMSFT
approved these changes
Sep 8, 2020
ghost
removed
the
Member
|
Approved for .NET 5 RC2. |
Pilchie
added
the
area-mvc
HaoK
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides fixes for:
This tweaks the templates for Blazor, Angular, MVC, Razor Pages, and Identity. So if someone from each of those product areas could please take a look, that would be valuable!