Make IdentityServer.Configuration.KeyDefinition linker friendly #25524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
|
@benaadams did you close and reopen to re-trigger the build? If this happens you can just ping me and I'll re-trigger the checks from AzDo. That way it only triggers the failing ones, is faster and has a better chance of success. |
Member
Author
Yes
Ok |
Member
|
@javiercn I'm going to assume you sign off on this code review as well. |
Pilchie
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged #25487 but retargeted for release/5.0-rc2 (that was merged to master thought it was approved for 5.0-rc2)
/cc @javiercn @Pilchie