Make IdentityServer.Configuration.KeyDefinition linker friendly #25487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bind directly rather than using configuration.Bind(key)
ghost
added
the
javiercn
approved these changes
Sep 1, 2020
Member
|
@Pilchie The changes have low impact and the tests pass. I'm happy if you decide to merge it for RC1 or wait for RC2 or 6.0. |
Member
|
Approved for RC1. |
Pilchie
added
the
community-contribution
Member
Author
|
@javiercn if this was merged to master, should I add another PR to add it to RC2 branch? (or other branch) |
Member
|
@benaadams Yes, this needs to go in RC2, thanks for sending the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind directly rather than using configuration.Bind(key)
Same issue as #25482