Skip to content

Quarantining flaky tests #25405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Quarantining flaky tests #25405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ProjectTemplates/test/WorkerTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public WorkerTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHelpe
[OSSkipCondition(OperatingSystems.Linux, SkipReason = "https://github.com/dotnet/sdk/issues/12831")]
[InlineData("C#")]
[InlineData("F#")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25404")]
Copy link
Contributor Author

@JunTaoLuo JunTaoLuo Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a long running test but the failing build didn't timeout and instead failed so I'm quarantining this instead of disabling outright.

public async Task WorkerTemplateAsync(string language)
{
Project = await ProjectFactory.GetOrCreateProject(
Expand Down
1 change: 1 addition & 0 deletions src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, string
[ConditionalTheory]
[MemberData(nameof(AddressRegistrationDataIPv6))]
[IPv6SupportedCondition]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25403")]
Copy link
Member

@halter73 halter73 Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could quarantine tests on specific platforms.

public async Task RegisterAddresses_IPv6_Success(string addressInput, string[] testUrls)
{
await RegisterAddresses_Success(addressInput, testUrls);
Expand Down