Quarantining flaky tests #25405
Merged
Quarantining flaky tests #25405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
requested review from
Tratcher,
halter73 and
jkotalik
as code owners
JunTaoLuo
commented
Aug 29, 2020
| [OSSkipCondition(OperatingSystems.Linux, SkipReason = "https://github.com/dotnet/sdk/issues/12831")] | ||
| [InlineData("C#")] | ||
| [InlineData("F#")] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25404")] |
Contributor
Author
There was a problem hiding this comment.
This causes a long running test but the failing build didn't timeout and instead failed so I'm quarantining this instead of disabling outright.
Pilchie
added
area-mvc
halter73
approved these changes
Aug 31, 2020
halter73
reviewed
Aug 31, 2020
| [ConditionalTheory] | ||
| [MemberData(nameof(AddressRegistrationDataIPv6))] | ||
| [IPv6SupportedCondition] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25403")] |
Member
There was a problem hiding this comment.
It would be nice if we could quarantine tests on specific platforms.
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/dotnet/aspnetcore-internal/issues/3667