Allow ProblemDetails \ ValidationProblemDetails to be more testable #24985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
commented
Aug 17, 2020
| detail: detail, | ||
| instance: instance); | ||
| ProblemDetails problemDetails; | ||
| if (ProblemDetailsFactory == null) |
Contributor
Author
There was a problem hiding this comment.
We have some precedence for having test-only code paths in Controller \ ControllerBase (e.g.
aspnetcore/src/Mvc/Mvc.Core/src/ControllerBase.cs
Lines 75 to 78 in f401f98
ProblemDetails \ ValidationProblemDetails in the action.
dougbu
reviewed
Aug 18, 2020
| Invoke-Expression "& $PSScriptRoot\dotnet-install.ps1 -Architecture $arch -Version $sdkVersion -InstallDir $installDir -NoPath" | ||
| Write-Host "Installing Runtime...& $PSScriptRoot\dotnet-install.ps1 -Architecture $arch -Runtime dotnet -Version $runtimeVersion -InstallDir $installDir -NoPath" | ||
| Invoke-Expression "& $PSScriptRoot\dotnet-install.ps1 -Architecture $arch -Runtime dotnet -Version $runtimeVersion -InstallDir $installDir -NoPath" | ||
| Write-Host "InstallDotNet.ps1 complete..." |
Contributor
Member
There was a problem hiding this comment.
Okay I can file another PR unless we want it to go in with this one?
Contributor
There was a problem hiding this comment.
For tracking, better separate but it's up to @pranavkm if validation passes this time
Contributor
Author
There was a problem hiding this comment.
Sorry missed this. I changed the branch after I created it, let me rebase on 5.0 since this build is busted anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15166