Helix pass in -nopath for dotnet-install #24968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
dougbu
approved these changes
Aug 17, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Do the dotnet-install.sh commands in runtests.sh also need to change❔
Member
Author
|
The path issue is just on windows arm boxes and the global path, we haven't seen any issues with the sh side of things |
MattGal
approved these changes
Aug 17, 2020
Member
If we're talking ARM64, another key difference is that ARM64 linux scenarios can and do use Docker, so the OS they're running inside is effectively new every time. |
HaoK
added a commit
that referenced
this pull request
Aug 18, 2020
pranavkm
pushed a commit
that referenced
this pull request
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to prevent dotnet-install from modifying the system path, cc @MattGal