Skip to content

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jun 13, 2020

Addresses #22917.

@JunTaoLuo JunTaoLuo changed the title Johluo/fix daily Fix helix-matrix tests Jun 13, 2020
@JunTaoLuo JunTaoLuo force-pushed the johluo/fix-daily branch 2 times, most recently from 3878e5c to 6510970 Compare June 13, 2020 18:59
@JunTaoLuo JunTaoLuo marked this pull request as draft June 13, 2020 18:59
@JunTaoLuo JunTaoLuo marked this pull request as ready for review June 13, 2020 23:05
displayName: Restore interop projects
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
/p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert before merging

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 15, 2020
@JunTaoLuo
Copy link
Contributor Author

The tests in question have passed on all Windows queues so I'm considering this fixed. Reverting the helix matrix switch and merging soon.

@JunTaoLuo JunTaoLuo merged commit b40b1bb into master Jun 16, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/fix-daily branch June 16, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants