-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Move all quarantined tests to the aspnetcore-quarantined-tests pipeline #22445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d993dbe
Move quarantined tests out of main build
BrennanConroy e5c9953
update
BrennanConroy 9ba3667
update
BrennanConroy d09c20e
fixups
BrennanConroy e0f321b
need node
BrennanConroy ea3718f
no java
BrennanConroy 4b519ee
results
BrennanConroy 558c140
format
BrennanConroy eda5692
is test
BrennanConroy a1595e7
Results
BrennanConroy f01b886
move task
BrennanConroy 19ffc17
correct spacing
BrennanConroy 90068db
fix templates
BrennanConroy 8c47533
remove un-needed
BrennanConroy a9e55f5
Fixup appsettings.json
pranavkm d9f7c39
fb
BrennanConroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,10 +250,21 @@ private void ValidateAppWorksOffline(Project project, string listeningUri, bool | |
| TestBasicNavigation(project.ProjectName, skipFetchData: skipFetchData); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb) | ||
| [ConditionalFact] | ||
| // LocalDB doesn't work on non Windows platforms | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @javiercn
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, if we have to break them into two separate tests, so be it |
||
| [OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)] | ||
| public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB() | ||
| { | ||
| return BlazorWasmHostedTemplate_IndividualAuth_Works(true); | ||
| } | ||
|
|
||
| [Fact] | ||
| public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB() | ||
| { | ||
| return BlazorWasmHostedTemplate_IndividualAuth_Works(false); | ||
| } | ||
|
|
||
| private async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb) | ||
| { | ||
| var project = await ProjectFactory.GetOrCreateProject("blazorhostedindividual" + (useLocalDb ? "uld" : ""), Output); | ||
|
|
||
|
|
@@ -268,11 +279,11 @@ public async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb) | |
| Assert.Contains(".db", serverProjectFileContents); | ||
| } | ||
|
|
||
| var appSettings = ReadFile(serverProject.TemplateOutputDir, "appSettings.json"); | ||
| var appSettings = ReadFile(serverProject.TemplateOutputDir, "appsettings.json"); | ||
| var element = JsonSerializer.Deserialize<JsonElement>(appSettings); | ||
| var clientsProperty = element.GetProperty("IdentityServer").EnumerateObject().Single().Value.EnumerateObject().Single(); | ||
| var replacedSection = element.GetRawText().Replace(clientsProperty.Name, serverProject.ProjectName.Replace(".Server", ".Client")); | ||
| var appSettingsPath = Path.Combine(serverProject.TemplateOutputDir, "appSettings.json"); | ||
| var appSettingsPath = Path.Combine(serverProject.TemplateOutputDir, "appsettings.json"); | ||
| File.WriteAllText(appSettingsPath, replacedSection); | ||
|
|
||
| var publishResult = await serverProject.RunDotNetPublishAsync(); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.