Skip to content

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 2, 2020
@BrennanConroy BrennanConroy requested a review from a team June 2, 2020 00:21
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My questions / comments are all suggestions or nits except the ones about defaults and the extra steps for restore operations.

[InlineData(false)]
public async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb)
[ConditionalFact]
// LocalDB doesn't work on non Windows platforms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if we have to break them into two separate tests, so be it

@BrennanConroy BrennanConroy merged commit 7af5e5d into master Jun 2, 2020
@BrennanConroy BrennanConroy deleted the brecon/quarantine_move branch June 2, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants