Skip to content

Do not ship SiteExtension in previews #21786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020
Merged

Do not ship SiteExtension in previews #21786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ad33d
Do not ship SiteExtension in previews
BrennanConroy May 13, 2020
dbe9688
fb
BrennanConroy May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
<DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions>
<NoSemVer20>true</NoSemVer20>
<IsPackable>true</IsPackable>
<IsShipping>true</IsShipping>
<IsShipping Condition=" '$(PreReleaseVersionLabel)' == 'preview' ">false</IsShipping>
Copy link
Contributor

@dougbu dougbu May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my slight concern for this option is what might happen if we rebrand for an RC release prior to RTM. Should the site extensions ship in that RC?

Copy link
Contributor

@dougbu dougbu May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we remember, this is of course fine.

Copy link
Member Author

@BrennanConroy BrennanConroy May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine for an RC

<ReferenceReferenceAssemblies>false</ReferenceReferenceAssemblies>
<ReferenceImplementationAssemblies>true</ReferenceImplementationAssemblies>

Expand Down