Do not ship SiteExtension in previews #21786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dougbu
approved these changes
May 13, 2020
...re.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
Outdated
Show resolved
Hide resolved
Member
Author
|
I should probably move this PR to preview5 |
We've generally avoided shipping the SiteExtension in preview releases. I'll file an issue to track re-enabling near the end of 5.0.
BrennanConroy
force-pushed
the
brecon/noex
branch
from
2eb795b to
dbe9688
Compare
Member
|
Yes, let's get this in for Preview 5. |
dougbu
reviewed
May 13, 2020
| <NoSemVer20>true</NoSemVer20> | ||
| <IsPackable>true</IsPackable> | ||
| <IsShipping>true</IsShipping> | ||
| <IsShipping Condition=" '$(PreReleaseVersionLabel)' == 'preview' ">false</IsShipping> |
Contributor
There was a problem hiding this comment.
Oh, my slight concern for this option is what might happen if we rebrand for an RC release prior to RTM. Should the site extensions ship in that RC?
Contributor
There was a problem hiding this comment.
As long as we remember, this is of course fine.
Member
Author
There was a problem hiding this comment.
I think it should be fine for an RC
Member
Author
|
Someone with permission please merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've generally avoided shipping the SiteExtension in preview releases. (Plus the one we did push to NuGet didn't contain the 3.1 bits and was breaking the SiteExtension experience since App Service will just grab the highest versioned package)
I'll file an issue to track re-enabling near the end of 5.0.