Skip to content

[Helix] Reenable win8 helix queue #21552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2020
Merged

[Helix] Reenable win8 helix queue #21552

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f8ea65
Add back win8 helix queue
HaoK May 6, 2020
13cd489
Run all queues on PR
HaoK May 6, 2020
71e23a0
Stop running OSX in daily and PR queues
HaoK May 7, 2020
6fd72d8
Update ci.yml
HaoK May 8, 2020
7bee6f4
Update ci.yml
HaoK May 8, 2020
e94174b
Merge branch 'master' into helix/win8
HaoK May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/targets/Helix.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<!-- daily scheduled only queues -->
<ItemGroup Condition="'$(IsWindowsOnlyTest)' != 'true' AND '$(TargetArchitecture)' == 'x64' AND '$(IsHelixDaily)' == 'true'">
<HelixAvailableTargetQueue Include="Windows.7.Amd64.Open" Platform="Windows" />
<HelixAvailableTargetQueue Include="Windows.81.Amd64.Open" Platform="Windows" />
<HelixAvailableTargetQueue Include="Ubuntu.1804.Amd64.Open" Platform="Linux" />
<HelixAvailableTargetQueue Include="OSX.1014.Amd64.Open" Platform="Linux" />
Copy link
Contributor

@dougbu dougbu May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Do we have a macOS or OSX platform? Seems less like our Linux platforms every day 😈

Copy link
Member Author

@HaoK HaoK May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform is really windows or not windows at this point :)

<HelixAvailableTargetQueue Include="Centos.7.Amd64.Open" Platform="Linux" />
<HelixAvailableTargetQueue Include="Debian.8.Amd64.Open" Platform="Linux" />
<HelixAvailableTargetQueue Include="Debian.9.Amd64.Open" Platform="Linux" />
Expand Down