[Helix] Reenable win8 helix queue #21552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
Contributor
|
/azp run |
|
Pull request contains merge conflicts. |
Member
Author
|
Note: we were running OSX helix queues in both PRs and daily, which is just double running them on rolling builds. Fixing that in this PR too |
dougbu
reviewed
May 8, 2020
| <ItemGroup Condition="'$(IsWindowsOnlyTest)' != 'true' AND '$(TargetArchitecture)' == 'x64' AND '$(IsHelixDaily)' == 'true'"> | ||
| <HelixAvailableTargetQueue Include="Windows.81.Amd64.Open" Platform="Windows" /> | ||
| <HelixAvailableTargetQueue Include="Ubuntu.1804.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="OSX.1014.Amd64.Open" Platform="Linux" /> |
Contributor
There was a problem hiding this comment.
Just curious: Do we have a macOS or OSX platform? Seems less like our Linux platforms every day 😈
Member
Author
There was a problem hiding this comment.
Platform is really windows or not windows at this point :)
Contributor
Member
Author
|
That's a good question, I don't even see any test failures in the openapi test logs, just 26 tests passed and 4 skipped :/ https://helix.dot.net/api/2019-06-17/jobs/67e5400f-917e-4779-8e23-ae8f52d8053f/workitems/dotnet-microsoft.openapi.Tests--netcoreapp5.0/files/console.0ff64487.log |
Member
Author
|
Win8 has looked fine, reverting yaml changes |
Pilchie
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.