Skip to content

[release/9.5] Don't require gen_ai.system attribute on span events #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
+8 −2
Merged

[release/9.5] Don't require gen_ai.system attribute on span events #11735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Dashboard/Model/GenAI/GenAIVisualizerDialogViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ private static void CreateMessages(GenAIVisualizerDialogViewModel viewModel, Tel
// Attempt get get messages from span events.
foreach (var item in viewModel.Span.Events.OrderBy(i => i.Time))
{
if (GenAIHelpers.IsGenAISpan(item.Attributes) &&
TryMapEventName(item.Name, out var type))
// Detect GenAI messages by event name. Don't check for the gen_ai.system attribute because it's optional on events.
if (TryMapEventName(item.Name, out var type))
{
var content = item.Attributes.GetValue(GenAIHelpers.GenAIEventContent);
var parts = content != null ? DeserializeBody(type.Value, content) : [];
Expand Down
6 changes: 6 additions & 0 deletions tests/Aspire.Dashboard.Tests/Model/GenAIVisualizerDialogViewModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,12 @@ public void Create_GenAISpanEvents_HasMessages()
CreateSpanEvent(
name: "gen_ai.assistant.message",
startTime: 2,
attributes: [
KeyValuePair.Create(GenAIHelpers.GenAIEventContent, JsonSerializer.Serialize(new AssistantEvent { Content = "Assistant!" }, GenAIEventsContext.Default.AssistantEvent)),
]),
CreateSpanEvent(
name: "other_name_that_is_ignored",
startTime: 3,
attributes: [
KeyValuePair.Create(GenAIHelpers.GenAIEventContent, JsonSerializer.Serialize(new AssistantEvent { Content = "Assistant!" }, GenAIEventsContext.Default.AssistantEvent)),
KeyValuePair.Create(GenAIHelpers.GenAISystem, "System!"),
Expand Down