[release/9.5] Don't require gen_ai.system attribute on span events #11735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11735Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11735" |
joperezr
added
Servicing-approved
|
Customer reported, low risk. Approved. |
joperezr
approved these changes
Sep 30, 2025
davidfowl
approved these changes
Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11733 to release/9.5
/cc @JamesNK
Customer Impact
User reported issue that some GenAI messages weren't displayed in the visualizer. The problem is the dashboard incorrectly requires
gen_ai.systemattribute to be on span events, but the spec says they're only recommended: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/gen-ai/gen-ai-events.md#event-gen_aichoiceSemantic Kernel sometimes doesn't include the attribute. Its messages end up missing from the UI.
Removing the check for
gen_ai.systemis fine because we can still match on the event name to determine if a span event is AI related.Testing
Unit tests
Risk
Low
Regression?
No