Skip to content

Conversation

@pjcollins
Copy link
Member

Commit e4a75a8 removed some make magic that ensured Mono.Android.dll
would be built multiple times for additional supported API levels.

A couple of MSBuild tasks used to build multiple versions of
Mono.Android.dll have been moved out of the PackDotNet target used by
the Windows build and into the Mono.Android build to fix this.

Commit e4a75a8 removed some make magic that ensured Mono.Android.dll
would be built multiple times for additional supported API levels.

A couple of MSBuild tasks used to build multiple versions of
Mono.Android.dll have been moved out of the `PackDotNet` target used by
the Windows build and into the Mono.Android build to fix this.
@pjcollins
Copy link
Member Author

@jpobst can you try this out in #9594 to see if it can be used as a more permanent fix to the build there?

@jpobst
Copy link
Contributor

jpobst commented Dec 10, 2024

@jpobst can you try this out in #9594 to see if it can be used as a more permanent fix to the build there?

Updated my PR with this code (and removed the other workaround).

Results in:

(_BuildAdditionalApiLevels target) -> 
D:\a\_work\1\s\src\Mono.Android\Mono.Android.targets(245,5): error MSB4006: There is a circular dependency in the target dependency graph involving target "_BuildAdditionalApiLevels". [D:\a\_work\1\s\src\Mono.Android\Mono.Android.csproj::TargetFramework=net9.0]

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10682236&view=logs&j=cac0e8d3-0ef5-5d2b-b57e-e8fde7204df3&t=be422736-ce1e-556a-8845-3aca534882e6

I think the PR is largely done aside from fixing this issue, so you are welcome to commit fixes to #9594 if you want.

@pjcollins
Copy link
Member Author

Closing this and will continue on 9594.

@pjcollins pjcollins closed this Dec 10, 2024
@pjcollins pjcollins deleted the dev/pjc/monoandroidprev branch December 10, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants