[build] Remove make framework-assemblies target (#9269)

I'm often running `make leeroy` to test changes while building on macOS,
and I noticed that an extra handful of Mono.Android.csproj builds were
running each time. The `framework-assemblies` target that is declared
in the generated `rules.mk` file includes some additional project builds
that don't seem to be necessary in a .NET only world.

The build has been updated to stop generating `rules.mk` entirely, and
the make targets in `BuildEverything.mk` have been simplified.

Author: pjcollins

Makefile

@@ -24,7 +24,6 @@ all:
 	$(call DOTNET_BINLOG,all) $(MSBUILD_FLAGS) $(SOLUTION)
 	$(call DOTNET_BINLOG,setup-workload) -t:ConfigureLocalWorkload build-tools/create-packs/Microsoft.Android.Sdk.proj
 
--include bin/Build$(CONFIGURATION)/rules.mk
 
 ifeq ($(OS_NAME),)
 export OS_NAME       := $(shell uname)

build-tools/scripts/BuildEverything.mk

@@ -1,16 +1,5 @@
 .PHONY: leeroy jenkins leeroy-all
 
-#
-# framework-assemblies lives in bin/Build$(CONFIGURATION)/rules.mk generated by `make prepare`
-#
-# It has to be invoked with $(MAKE) because otherwise rules.mk would not be included and we'd
-# get a build failure.
-#
-# The other targets depended upon by leeroy also require rules.mk to be present and thus they
-# are invoked in the same way framework-assemblies is
-#
-# Local `make jenkins` invocations should build everything by default. We need to ensure `-a` is passed to xaprepare when no CI flags are set.
-#
 jenkins:
 ifeq ($(PREPARE_CI_PR)$(PREPARE_CI),00)
 	$(MAKE) PREPARE_ARGS=-a prepare
@@ -23,8 +12,6 @@ ifneq ("$(wildcard $(topdir)/external/monodroid/Makefile)","")
 endif
 	$(MAKE) leeroy
 
-leeroy: leeroy-all framework-assemblies
-
-leeroy-all:
-	$(call DOTNET_BINLOG,leeroy-all) $(SOLUTION) $(_MSBUILD_ARGS)
+leeroy:
+	$(call DOTNET_BINLOG,leeroy) $(SOLUTION) $(_MSBUILD_ARGS)
 	$(call DOTNET_BINLOG,setup-workload) -t:ConfigureLocalWorkload build-tools/create-packs/Microsoft.Android.Sdk.proj

build-tools/xaprepare/xaprepare/Application/Context.cs

@@ -42,7 +42,6 @@ partial class Context : AppObject
 		bool? useColor;
 		bool? dullMode;
 		Scenario? defaultScenario;
-		List<RuleGenerator>? ruleGenerators;
 		string? debugFileExtension;
 		CompressionFormat? compressionFormat;
 		Dictionary<KnownConditions, bool> conditions  = new Dictionary<KnownConditions, bool> ();
@@ -262,18 +261,6 @@ public string XAInstallPrefix {
 			}
 		}
 
-		/// <summary>
-		///   A collection of delegates which can add rules to the `rules.mk` file generated at the end of
-		///   bootstrapper's run
-		/// </summary>
-		public List<RuleGenerator> RuleGenerators {
-			get {
-				if (ruleGenerators == null)
-					ruleGenerators = new List<RuleGenerator> ();
-				return ruleGenerators;
-			}
-		}
-
 		/// <summary>
 		///   Extensions of files with debug information
 		/// </summary>

build-tools/xaprepare/xaprepare/Application/GeneratedMakeRulesFile.cs

@@ -146,23 +146,6 @@ public static partial class Defaults
 				{ "x86_64",         "x86_64-linux-android" },
 			};
 
-			/// <summary>
-			///   Used in rules.mk generator. Files to include in the XA bundle archives.
-			/// </summary>
-			public static readonly List <string> BundleZipsInclude = new List <string> {
-				"$(ZIP_OUTPUT_BASENAME)/THIRD-PARTY-NOTICES.TXT",
-				"$(ZIP_OUTPUT_BASENAME)/bin/Debug",
-				"$(ZIP_OUTPUT_BASENAME)/bin/Release",
-			};
-
-			/// <summary>
-			///   Used in rules.mk generator. Files to exclude from the XA bundle archives. Must be syntactically
-			///   correct for GNU Make.
-			/// </summary>
-			public static readonly List <string> BundleZipsExclude = new List <string> {
-				"$(ZIP_OUTPUT_BASENAME)/bin/*/bundle-*.zip"
-			};
-
 			public static readonly List <NDKTool> NDKTools = new List<NDKTool> {
 				// Tools prefixed with architecture triple
 				new NDKTool (name: "as", prefixed: true),

build-tools/xaprepare/xaprepare/Application/RuleGeneratorDelegate.cs

@@ -27,7 +27,6 @@ public override void Generate (Context context)
 
 		partial void AddUnixPostBuildSteps (Context context, List<GeneratedFile> steps)
 		{
-			steps.Add (new GeneratedMakeRulesFile (Path.Combine (Configurables.Paths.BuildBinDir, "rules.mk")));
 			steps.Add (new GeneratedConfigurationFile (Path.Combine (Configurables.Paths.BinDirRoot, "configuration.mk")));
 		}
 	}