[Xamarin.ProjectTools] Actually use MSBuild for the tests..... #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8643ded reworked the msbuild tests to use msbuild. But there was a problem with the logic. string.IsNullOrEmpty (useMSBuild) || useMSBuild == "0" well the Environment variable USE_MSBUILD will ALWAYS be empty. Because we never set it. so the logic should be !string.IsNullOrEmpty (useMSBuild) && useMSBuild == "0" so that if it is set it has to be "0" to allow xbuild to be used. Also one of the tests was using `RunningMSBuild` before it was calculated. So it was always false. So just added some logging to print what we are using to the console. This forces `RunningMSBuild` to be calculated. One final issue was with the intermediate .pdb files being cleaned up by `IncrementalClean`. Turns out we had a fix for the .mdb files in `Xamarin.Android.Windows.targets`. So the solution there was to add the same work around for .pdb files.
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
Commit 8643ded reworked the msbuild tests to use msbuild. But there was a problem with the logic. string.IsNullOrEmpty (useMSBuild) || useMSBuild == "0" well the Environment variable USE_MSBUILD will ALWAYS be empty. Because we never set it. so the logic should be !string.IsNullOrEmpty (useMSBuild) && useMSBuild == "0" so that if it is set it has to be "0" to allow xbuild to be used. Also one of the tests was using `RunningMSBuild` before it was calculated. So it was always false. So just added some logging to print what we are using to the console. This forces `RunningMSBuild` to be calculated. One final issue was with the intermediate .pdb files being cleaned up by `IncrementalClean`. Turns out we had a fix for the .mdb files in `Xamarin.Android.Windows.targets`. So the solution there was to add the same work around for .pdb files.
jonpryor
pushed a commit
that referenced
this pull request
Mar 2, 2022
Partially fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1467817 Changes: dotnet/java-interop@cbd9666...aae23c9 * dotnet/java-interop@aae23c97: [Java.Interop] use $(DebugType)=portable (#958) * dotnet/java-interop@1987829f: [ci] Move CI builds to 1ES's hardened images. (#953) A warning is printed when building with `-p:MonoSymbolArchive=true`: Warning: Directory obj\Release\120\android\assets contains Java.Interop.dll but no debug symbols file was found. It turns out we are missing `Java.Interop.pdb` from our installer! Update to dotnet/java-interop@aae23c97, which allows `Java.Interop.pdb` to be built, and add `Java.Interop.pdb`, `Mono.Posix.pdb`, and `System.EnterpriseServices.pdb` to our `.vsix` installer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8643ded reworked the msbuild tests to use msbuild. But
there was a problem with the logic.
well the Environment variable USE_MSBUILD will ALWAYS be empty.
Because we never set it. so the logic should be
so that if it is set it has to be "0" to allow xbuild to be
used.
Also one of the tests was using
RunningMSBuildbefore it wascalculated. So it was always false. So just added some logging to
print what we are using to the console. This forces
RunningMSBuildto be calculated.
One final issue was with the intermediate .pdb files being cleaned
up by
IncrementalClean. Turns out we had a fix for the .mdb filesin
Xamarin.Android.Windows.targets. So the solution there was toadd the same work around for .pdb files.