[runtime] Use a set of properties to pass common configure flags #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
added
the
full-mono-integration-build
grendello
force-pushed
the
common-configure-flags
branch
2 times, most recently
from
407c925 to
906070d
Compare
akoeplinger
reviewed
Oct 18, 2017
| <RanLib>$(AndroidMxeFullPath)\bin\$(MingwCommandPrefix64)-ranlib</RanLib> | ||
| <Strip>$(AndroidMxeFullPath)\bin\$(MingwCommandPrefix64)-strip</Strip> | ||
| <ConfigureFlags>PATH="$PATH:$(AndroidMxeFullPath)\bin" --host=$(MingwCommandPrefix64) --target=$(MingwCommandPrefix64) --disable-boehm --enable-mcs-build=no --enable-nls=no --enable-maintainer-mode --with-monodroid --disable-llvm ac_cv_header_zlib_h=no ac_cv_search_dlopen=no</ConfigureFlags> | ||
| <ConfigureFlags>PATH="$PATH:$(AndroidMxeFullPath)\bin" --host=$(MingwCommandPrefix64) --target=$(MingwCommandPrefix64) $(_CommonHostConfigureFlags) --disable-dynamic-btls --disable-mcs-build --disable-llvm ac_cv_header_zlib_h=no ac_cv_search_dlopen=no</ConfigureFlags> |
Member
There was a problem hiding this comment.
You can remove --disable-dynamic-btls and --enable-dynamic-btls below since BTLS is always dynamic now.
If the intention here was to disable BTLS completely on host runtimes then you'd need to pass --disable-btls
grendello
force-pushed
the
common-configure-flags
branch
from
906070d to
08f4dc6
Compare
DRY - do not repeat configure args across various runtimes.
grendello
force-pushed
the
common-configure-flags
branch
from
08f4dc6 to
dd7aca6
Compare
Contributor
|
I don't know why, but everything failed. Consider the Ubuntu+xbuild PR Build log: |
Contributor
Author
|
I saw it locally, it disappeared as mysteriously as it appeared. Let's see if it builds now. |
Contributor
Author
|
build |
Contributor
Author
|
build |
Contributor
|
@grendello: is this PR still relevant/needed? We're now using Mono's "sdks" to build the runtime, so many of the changes in this PR are obsolete. The changes for |
Contributor
|
This PR is obsolete because we're now using mono's "sdks" feature for mono builds. |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 16, 2021
Fixes: dotnet/java-interop#857 Changes: dotnet/java-interop@087684a...0293360 * dotnet/java-interop@0293360a: [Xamarin.Android.Tools.Bytecode] NRT Support (dotnet#913) * dotnet/java-interop@e85564c1: [generator] Import NRT data from managed assemblies (dotnet#912) * dotnet/java-interop@c476cc39: [ci] Update to use VS2022 build agents (dotnet#914)
jonpryor
added a commit
that referenced
this pull request
Nov 17, 2021
Fixes: dotnet/java-interop#857 Changes: dotnet/java-interop@087684a...0293360 * dotnet/java-interop@0293360a: [Xamarin.Android.Tools.Bytecode] NRT Support (#913) * dotnet/java-interop@e85564c1: [generator] Import NRT data from managed assemblies (#912) * dotnet/java-interop@c476cc39: [ci] Update to use VS2022 build agents (#914)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY - do not repeat configure args across various runtimes.