Skip to content

Conversation

@akoeplinger
Copy link
Member

It isn't required to build the monodroid profile and saves a lot of build time.

It isn't required to build the monodroid profile and saves a lot of build time.
@akoeplinger akoeplinger added the do-not-merge PR should not be merged. label Oct 3, 2017
@jonpryor
Copy link
Contributor

jonpryor commented Oct 4, 2017

The PR build fails:

mono-runtimes.targets: error : Cannot copy /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/external/mono/mcs/class/lib/net_4_x/mono-cil-strip.pdb to /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/cil-strip.pdb, as the source file doesn't exist.

We need cil-strip{.exe,.pdb}; see also:

My guess is that you need to update $(_MonoOutputDir) to reference whatever profile/directory contains mono-cil-strip.exe.

@akoeplinger
Copy link
Member Author

Yeah this was more complicated than I initially thought. We'll need mono/mono#5699 first.

@akoeplinger akoeplinger closed this Oct 4, 2017
@akoeplinger akoeplinger deleted the disable-net_4_x branch October 17, 2017 02:21
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Nov 16, 2021
Fixes: dotnet/java-interop#857

Changes: dotnet/java-interop@087684a...0293360

  * dotnet/java-interop@0293360a: [Xamarin.Android.Tools.Bytecode] NRT Support (dotnet#913)
  * dotnet/java-interop@e85564c1: [generator] Import NRT data from managed assemblies (dotnet#912)
  * dotnet/java-interop@c476cc39: [ci] Update to use VS2022 build agents (dotnet#914)
jonpryor added a commit that referenced this pull request Nov 17, 2021
Fixes: dotnet/java-interop#857

Changes: dotnet/java-interop@087684a...0293360

  * dotnet/java-interop@0293360a: [Xamarin.Android.Tools.Bytecode] NRT Support (#913)
  * dotnet/java-interop@e85564c1: [generator] Import NRT data from managed assemblies (#912)
  * dotnet/java-interop@c476cc39: [ci] Update to use VS2022 build agents (#914)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge PR should not be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants