[Xamarin.Android.Build.Tasks] Move LintToolPath Check #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=57532#c5 @pjcollins notes that if `lint` isn't installed *and isn't used*, commit 010332d will generate a build error -- because `lint` can't be found -- and this isn't necessarily warranted. It could be a backward compatibility break. Move the `lint` path check into the `<Lint/>` task so that we only generate an XA5205 error if `lint` can't be found *and* we're attempting to use `lint`.
jonpryor
added a commit
that referenced
this pull request
Jun 22, 2017
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=57532#c5 @pjcollins notes that if `lint` isn't installed *and isn't used*, commit 010332d will generate a build error -- because `lint` can't be found -- and this isn't necessarily warranted. It could be a backward compatibility break. Move the `lint` path check into the `<Lint/>` task so that we only generate an XA5205 error if `lint` can't be found *and* we're attempting to use `lint`.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@76d1ac7...1f3388a * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (dotnet#658) * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@76d1ac7...1f3388a * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (dotnet#658) * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@76d1ac7...1f3388a * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (#662) * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (#659) * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (#660) * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (#658) * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (#652) * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (#650) * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (#651)
jonpryor
added a commit
that referenced
this pull request
Jun 16, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (#651)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=57532#c5
@pjcollins notes that if
lintisn't installed and isn't used,commit 010332d will generate a build error -- because
lintcan't befound -- and this isn't necessarily warranted. It could be a backward
compatibility break.
Move the
lintpath check into the<Lint/>task so that we onlygenerate an XA5205 error if
lintcan't be found and we'reattempting to use
lint.