[Xamarin.Android.Build.Tasks] Make use of the ProductVersion information in the Common.props #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in the Common.props At [1] we already attempt to replace the Product and Version information in the Xamarin.Android.Common.props.in file. However the props.in file did not have the appropriate text to replace in it. This commit fixes that issue so we get the correct information. [1] https://github.com/xamarin/xamarin-android/blob/master/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets#L129
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 15, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)
jonpryor
added a commit
that referenced
this pull request
Jun 16, 2020
Changes: dotnet/java-interop@b00e644...1de5501 * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (#655) * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (#662) * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (#659) * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (#660) * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (#657) * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (#656) * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (#658) * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (#654) * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (#652) * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (#650) * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (#651)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At [1] we already attempt to replace the Product and Version information
in the Xamarin.Android.Common.props.in file. However the props.in file
did not have the appropriate text to replace in it.
This commit fixes that issue so we get the correct information.
[1] https://github.com/xamarin/xamarin-android/blob/master/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets#L129