[ci] Make logging less verbose #6322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
changed the title
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
It looks like this is in more .yaml files, should we updates this one, too?
Member
|
We maybe want to remove this from the JI prepare step as well: https://github.com/xamarin/xamarin-android/blob/6467cda58822b4405a8a105a3268bd5341230187/build-tools/xaprepare/xaprepare/Steps/Step_PrepareExternalJavaInterop.Unix.cs#L24 My only concern with this would be losing out on potential information we get from passing |
grendello
approved these changes
Sep 22, 2021
pjcollins
approved these changes
Sep 22, 2021
jonathanpeppers
approved these changes
Sep 22, 2021
jonathanpeppers
pushed a commit
that referenced
this pull request
Sep 24, 2021
Context: https://twitter.com/KirillOsenkov/status/1440192351528374279 > Too often I see a build taking upwards of 10-20 minutes with all > sorts of text loggers (file loggers, console loggers), worst of all > text loggers of diagnostic verbosity. > > Text loggers absolutely kill your build performance. Our verbose logging is getting a little out of control. The `make jenkins` log is ~870 MB and can no longer be viewed in the AzDO UI. Remove `V=1` from our `make` invocations, which removes `/v:diag`. Timings aren't stable across build agents so numbers aren't very accurate, but there are definitely improvements: - Log file of `make jenkins` went from 870 MB to 32 MB - Build time of `make jenkins` went from 42:49 to 34:43 Full logs are still available in the `.binlog`'s we already produce and place in artifacts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://twitter.com/KirillOsenkov/status/1440192351528374279
Our verbose logging is getting a little out of control. The
make jenkinslog is ~870 MB and can no longer be viewed in the AzDO UI.Remove
V=1from our invocations, which removes/v:diag.Timings aren't stable across build agents so numbers aren't very accurate, but there are definitely improvements:
make jenkinswent from 870 MB to 32 MBmake jenkinswent from 42:49 to 34:43Full logs are still available in the
.binlog's we already produce and place in artifacts.