Skip to content

Commit e2a0d56

Browse files
jpobstjpobst
authored
[ci] Make logging less verbose (#6322)
Context: https://twitter.com/KirillOsenkov/status/1440192351528374279 > Too often I see a build taking upwards of 10-20 minutes with all > sorts of text loggers (file loggers, console loggers), worst of all > text loggers of diagnostic verbosity. > > Text loggers absolutely kill your build performance. Our verbose logging is getting a little out of control. The `make jenkins` log is ~870 MB and can no longer be viewed in the AzDO UI. Remove `V=1` from our `make` invocations, which removes `/v:diag`. Timings aren't stable across build agents so numbers aren't very accurate, but there are definitely improvements: - Log file of `make jenkins` went from 870 MB to 32 MB - Build time of `make jenkins` went from 42:49 to 34:43 Full logs are still available in the `.binlog`'s we already produce and place in artifacts.
1 parent 7d45558 commit e2a0d56

File tree

4 files changed

+25
-26
lines changed

4 files changed

+25
-26
lines changed

‎build-tools/automation/azure-pipelines-oss.yaml‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -91,26 +91,26 @@ stages:
9191
9292
# Prepare and build everything
9393
- script: >
94-
echo "make prepare-update-mono V=1 CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'" &&
95-
make prepare-update-mono V=1 CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'
94+
echo "make prepare-update-mono CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'" &&
95+
make prepare-update-mono CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'
9696
workingDirectory: $(Build.SourcesDirectory)
9797
displayName: make prepare-update-mono
9898
9999
- script: >
100-
echo "make prepare CONFIGURATION=$(XA.Build.Configuration) V=1 $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'" &&
101-
make prepare CONFIGURATION=$(XA.Build.Configuration) V=1 $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'
100+
echo "make prepare CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'" &&
101+
make prepare CONFIGURATION=$(XA.Build.Configuration) $(PREPARE_FLAGS) MSBUILD_ARGS='$(EXTRA_MSBUILD_ARGS)'
102102
workingDirectory: $(Build.SourcesDirectory)
103103
displayName: make prepare
104104
105105
- script: >
106-
echo "make jenkins V=1 CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1" &&
107-
make jenkins V=1 CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1
106+
echo "make jenkins CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1" &&
107+
make jenkins CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1
108108
workingDirectory: $(Build.SourcesDirectory)
109109
displayName: make jenkins
110110
111111
- script: >
112-
echo "make create-installers V=1 CONFIGURATION=$(XA.Build.Configuration)" &&
113-
make create-installers V=1 CONFIGURATION=$(XA.Build.Configuration)
112+
echo "make create-installers CONFIGURATION=$(XA.Build.Configuration)" &&
113+
make create-installers CONFIGURATION=$(XA.Build.Configuration)
114114
workingDirectory: $(Build.SourcesDirectory)
115115
displayName: create installers
116116
@@ -134,20 +134,20 @@ stages:
134134
targetPath: $(Build.SourcesDirectory)/bin/Build$(XA.Build.Configuration)/$(NuGetArtifactName)
135135

136136
- script: >
137-
echo "all-tests CONFIGURATION=$(XA.Build.Configuration) V=1" &&
138-
make all-tests CONFIGURATION=$(XA.Build.Configuration) V=1
137+
echo "all-tests CONFIGURATION=$(XA.Build.Configuration)" &&
138+
make all-tests CONFIGURATION=$(XA.Build.Configuration)
139139
workingDirectory: $(Build.SourcesDirectory)
140140
displayName: make all-tests
141141
142142
- script: >
143-
echo "make package-build-status CONFIGURATION=$(XA.Build.Configuration) V=1" &&
144-
make package-build-status CONFIGURATION=$(XA.Build.Configuration) V=1
143+
echo "make package-build-status CONFIGURATION=$(XA.Build.Configuration)" &&
144+
make package-build-status CONFIGURATION=$(XA.Build.Configuration)
145145
workingDirectory: $(Build.SourcesDirectory)
146146
displayName: package build status
147147
148148
- script: >
149-
echo "make run-performance-tests CONFIGURATION=$(XA.Build.Configuration) V=1" &&
150-
make run-performance-tests CONFIGURATION=$(XA.Build.Configuration) V=1
149+
echo "make run-performance-tests CONFIGURATION=$(XA.Build.Configuration)" &&
150+
make run-performance-tests CONFIGURATION=$(XA.Build.Configuration)
151151
workingDirectory: $(Build.SourcesDirectory)
152152
displayName: run performance tests
153153
condition: and(succeeded(), eq(variables['EnableTestExecution'], 'true')) # The variable is defined on the pipeline definition
@@ -174,16 +174,16 @@ stages:
174174

175175
- template: yaml-templates/setup-ubuntu.yaml
176176

177-
- script: make prepare V=1 PREPARE_CI_PR=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
177+
- script: make prepare PREPARE_CI_PR=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
178178
displayName: make prepare
179179

180-
- script: make jenkins V=1 PREPARE_CI_PR=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
180+
- script: make jenkins PREPARE_CI_PR=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
181181
displayName: make jenkins
182182

183-
- script: make create-nupkgs V=1 CONFIGURATION=$(XA.Build.Configuration)
183+
- script: make create-nupkgs CONFIGURATION=$(XA.Build.Configuration)
184184
displayName: make create-nupkgs
185185

186-
- script: make package-deb V=1 CONFIGURATION=$(XA.Build.Configuration)
186+
- script: make package-deb CONFIGURATION=$(XA.Build.Configuration)
187187
displayName: make package-deb
188188

189189
- script: >

‎build-tools/automation/azure-pipelines.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ stages:
442442
workingDirectory: $(System.DefaultWorkingDirectory)/xamarin-android
443443
displayName: make prepare
444444

445-
- script: make jenkins V=1 PREPARE_CI=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
445+
- script: make jenkins PREPARE_CI=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=$(XA.Build.Configuration)
446446
workingDirectory: $(System.DefaultWorkingDirectory)/xamarin-android
447447
displayName: make jenkins
448448

@@ -508,7 +508,7 @@ stages:
508508
- script: mono $(System.DefaultWorkingDirectory)/build-tools/xaprepare/xaprepare/bin/$(ApkTestConfiguration)/xaprepare.exe --s=EmulatorTestDependencies --no-emoji --run-mode=CI
509509
displayName: install emulator
510510

511-
- script: make prepare V=1 CONFIGURATION=$(ApkTestConfiguration) JI_JAVA_HOME=$(JI_JAVA_HOME) JAVA_HOME=$(JI_JAVA_HOME)
511+
- script: make prepare CONFIGURATION=$(ApkTestConfiguration) JI_JAVA_HOME=$(JI_JAVA_HOME) JAVA_HOME=$(JI_JAVA_HOME)
512512
workingDirectory: $(System.DefaultWorkingDirectory)/external/Java.Interop
513513
displayName: prepare java.interop
514514

@@ -759,7 +759,7 @@ stages:
759759
- script: mono $(System.DefaultWorkingDirectory)/build-tools/xaprepare/xaprepare/bin/$(XA.Build.Configuration)/xaprepare.exe --s=EmulatorTestDependencies --no-emoji --run-mode=CI
760760
displayName: install emulator
761761

762-
- script: make prepare V=1 CONFIGURATION=$(XA.Build.Configuration) JI_JAVA_HOME=$(JI_JAVA_HOME) JAVA_HOME=$(JI_JAVA_HOME)
762+
- script: make prepare CONFIGURATION=$(XA.Build.Configuration) JI_JAVA_HOME=$(JI_JAVA_HOME) JAVA_HOME=$(JI_JAVA_HOME)
763763
workingDirectory: $(System.DefaultWorkingDirectory)/external/Java.Interop
764764
displayName: prepare java.interop
765765

‎build-tools/automation/yaml-templates/commercial-build.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ steps:
2626
provisioning_script: ${{ parameters.xaSourcePath }}/build-tools/provisioning/xcode.csx
2727
provisioning_extra_args: '-v -v -v -v'
2828

29-
- script: make prepare-update-mono V=1 CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1
29+
- script: make prepare-update-mono CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1
3030
workingDirectory: ${{ parameters.xaSourcePath }}
3131
displayName: make prepare-update-mono
3232

@@ -46,12 +46,12 @@ steps:
4646
displayName: make prepare-external-git-dependencies
4747

4848
# Prepare and Build everything
49-
- script: make jenkins V=1 CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1 MSBUILD_ARGS='${{ parameters.makeMSBuildArgs }}'
49+
- script: make jenkins CONFIGURATION=$(XA.Build.Configuration) PREPARE_CI=1 PREPARE_AUTOPROVISION=1 MSBUILD_ARGS='${{ parameters.makeMSBuildArgs }}'
5050
workingDirectory: ${{ parameters.xaSourcePath }}
5151
displayName: make jenkins
5252

5353
# Build and package test assemblies
54-
- script: make all-tests V=1 CONFIGURATION=$(XA.Build.Configuration)
54+
- script: make all-tests CONFIGURATION=$(XA.Build.Configuration)
5555
workingDirectory: ${{ parameters.xaSourcePath }}
5656
displayName: make all-tests
5757

@@ -85,7 +85,7 @@ steps:
8585
/p:MicroBuildOverridePluginDirectory=$(Build.StagingDirectory)/MicroBuild/Plugins
8686
/bl:${{ parameters.xaSourcePath }}/bin/Build$(XA.Build.Configuration)/restore-sign-pkg-content.binlog
8787
88-
- script: make create-installers V=1 CONFIGURATION=$(XA.Build.Configuration)
88+
- script: make create-installers CONFIGURATION=$(XA.Build.Configuration)
8989
workingDirectory: ${{ parameters.xaSourcePath }}
9090
displayName: make create-installers
9191

‎build-tools/xaprepare/xaprepare/Steps/Step_PrepareExternalJavaInterop.Unix.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ async Task<bool> ExecuteOSSpecific (Context context)
2121
workingDirectory: javaInteropDir,
2222
arguments: new List <string> {
2323
"prepare",
24-
"V=1",
2524
$"CONFIGURATION={context.Configuration}",
2625
$"JI_JAVA_HOME={context.OS.JavaHome}",
2726
$"JAVA_HOME={context.OS.JavaHome}",

0 commit comments

Comments
 (0)