[Xamarin.Android.Build.Tasks] Make use of --bundled-header when using mkbundle. #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jonp this PR changes over to use the mono/2017-04 branch. we should hold off until you are happy to bump to that branch |
|
@jonpryor ^^^ |
Contributor
|
@jonp: ...yes? I do not understand your question or intent. Assuming that you're asking "when will we merge PR #551", we'll merge PR #551 when we figure out a way to get builds working reliably on Linux, as I don't want that to be broken for extensive periods of time. This should hopefully be done before the end of the month. |
|
@jonpryor just tagging you since I was tagged in error |
Contributor
Author
|
Going to back out the mono bump in this PR in favour of the following PR |
Contributor
Author
|
build |
… mkbundle. We no longer build mkbundle manually. Instead we make use of the system mono version. This commit makes sure we don't have a dependency on having mono installed by using the --bundled-header flag for mkbundle. --bundled-header makes sure the generated code does not require mono-config.h. This means it will compile without mono being installed. Which is important on windows since most users will NOT have mono.
jonpryor
pushed a commit
that referenced
this pull request
Feb 22, 2020
Changes: dotnet/java-interop@b81cfbb...4f47ec8 Fixes: dotnet/java-interop#572 Context: dotnet/project-system#1821 Context: dotnet/java-interop#509 * dotnet/java-interop@4f47ec8: [generator] Make DIM invoking plumbing private (#581) * dotnet/java-interop@2a0f863: [Java.Interop.sln] Let VS update the project type guids. (#579) * dotnet/java-interop@9a01c9b: [Java.Interop.Tools.Cecil] remove System.Linq in IsSubclassOf (#577) * dotnet/java-interop@cd33da6: [generator] Bind protected nested types (#578) * dotnet/java-interop@fa10e98 :[generator] Do bind package-private nested types (#575)
jonpryor
pushed a commit
that referenced
this pull request
Feb 24, 2020
Changes: dotnet/java-interop@e92f341...178e849 Fixes: dotnet/java-interop#572 Context: dotnet/project-system#1821 Context: dotnet/java-interop#509 * dotnet/java-interop@178e849: [generator] Make DIM invoking plumbing private (#581) * dotnet/java-interop@b7b10bc: [Java.Interop.sln] Let VS update the project type guids. (#579) * dotnet/java-interop@3c590a4: [Java.Interop.Tools.Cecil] remove System.Linq in IsSubclassOf (#577) * dotnet/java-interop@d1bbed7: [generator] Bind protected nested types (#578) * dotnet/java-interop@5db30a8: [generator] Do bind package-private nested types (#575)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer build mkbundle manually. Instead we make use of the
system mono version. This commit makes sure we don't have a
dependency on having mono installed by using the --bundled-header
flag for mkbundle.
--bundled-header makes sure the generated code does not require
mono-config.h. This means it will compile without mono being
installed. Which is important on windows since most users will NOT
have mono.