[create-vsix] Allow overriding the created .vsix filename #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the `make create-vsix` target to create the commercial `Xamarin.Android.Sdk.vsix` file, but we want it to have a different filename, matching commit + commit count information from the internal `monodroid` repo, not the xamarin-android repo. Uppdate `create-vsix.csproj` to accept a new `$(VsixPath)` property, which is the path of the .vsix file to create. Update the default `$(VsixPath)` filename to be `Xamarin.Android.Sdk-OSS*`, so that if a customer downloads both a Jenkins OSS build and a commercial .vsix build, it will be easier to differentiate between them. (The `.vsix` package name information is *not* changed, thus it is not possible to concurrently have both the commercial and OSS builds installed in the same VS 2017 SKU.) Update the `make create-vsix` target so that the output path and other MSBuild properties can more easily be overridden: make create-vsix CONFIGURATIONS=Debug VSIX=`pwd`/MyNewPackage.vsix The `$(VSIX)` **make**(1) variable sets the `$(VsixPath)` MSBuild property. *Note*: the current-working-directory for `make create-vsix` is `build-tools/create-vsix`; consequently, this command: make create-vsix CONFIGURATIONS=Debug VSIX=MyNewPackage.vsix will create `./build-tools/create-vsix/MyNewPackage.vsix`, *not* `./MyNewPackage.vsix`.
dellis1972
requested changes
Apr 27, 2017
| <UsingTask AssemblyFile="..\..\bin\Build$(Configuration)\xa-prep-tasks.dll" TaskName="Xamarin.Android.BuildTools.PrepTasks.GitBranch" /> | ||
| <UsingTask AssemblyFile="..\..\bin\Build$(Configuration)\xa-prep-tasks.dll" TaskName="Xamarin.Android.BuildTools.PrepTasks.GitCommitHash" /> | ||
| <UsingTask AssemblyFile="..\..\bin\Build$(Configuration)\xa-prep-tasks.dll" TaskName="Xamarin.Android.BuildTools.PrepTasks.GitCommitsInRange" /> | ||
| <Import Project="..\scripts\XAVersionInfo.targets" /> |
Contributor
There was a problem hiding this comment.
Are we missing this file? I can't see it in the PR
Contributor
Author
There was a problem hiding this comment.
Are we missing this file?
Nope; it's here: https://github.com/xamarin/xamarin-android/blob/master/build-tools/scripts/XAVersionInfo.targets
dellis1972
approved these changes
Apr 28, 2017
jonpryor
pushed a commit
that referenced
this pull request
Feb 22, 2020
Changes: dotnet/java-interop@b81cfbb...4f47ec8 Fixes: dotnet/java-interop#572 Context: dotnet/project-system#1821 Context: dotnet/java-interop#509 * dotnet/java-interop@4f47ec8: [generator] Make DIM invoking plumbing private (#581) * dotnet/java-interop@2a0f863: [Java.Interop.sln] Let VS update the project type guids. (#579) * dotnet/java-interop@9a01c9b: [Java.Interop.Tools.Cecil] remove System.Linq in IsSubclassOf (#577) * dotnet/java-interop@cd33da6: [generator] Bind protected nested types (#578) * dotnet/java-interop@fa10e98 :[generator] Do bind package-private nested types (#575)
jonpryor
pushed a commit
that referenced
this pull request
Feb 24, 2020
Changes: dotnet/java-interop@e92f341...178e849 Fixes: dotnet/java-interop#572 Context: dotnet/project-system#1821 Context: dotnet/java-interop#509 * dotnet/java-interop@178e849: [generator] Make DIM invoking plumbing private (#581) * dotnet/java-interop@b7b10bc: [Java.Interop.sln] Let VS update the project type guids. (#579) * dotnet/java-interop@3c590a4: [Java.Interop.Tools.Cecil] remove System.Linq in IsSubclassOf (#577) * dotnet/java-interop@d1bbed7: [generator] Bind protected nested types (#578) * dotnet/java-interop@5db30a8: [generator] Do bind package-private nested types (#575)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the
make create-vsixtarget to create the commercialXamarin.Android.Sdk.vsixfile, but we want it to have a differentfilename, matching commit + commit count information from the internal
monodroidrepo, not the xamarin-android repo.Uppdate
create-vsix.csprojto accept a new$(VsixPath)property,which is the path of the .vsix file to create.
Update the default
$(VsixPath)filename to beXamarin.Android.Sdk-OSS*, so that if a customer downloads both aJenkins OSS build and a commercial .vsix build, it will be easier to
differentiate between them. (The
.vsixpackage name information isnot changed, thus it is not possible to concurrently have both the
commercial and OSS builds installed in the same VS 2017 SKU.)
Update the
make create-vsixtarget so that the output path and otherMSBuild properties can more easily be overridden:
The
$(VSIX)make(1) variable sets the$(VsixPath)MSBuildproperty.
Note: the current-working-directory for
make create-vsixisbuild-tools/create-vsix; consequently, this command:will create
./build-tools/create-vsix/MyNewPackage.vsix, not./MyNewPackage.vsix.