Adding api-versions.xml based on the AndroidApiLevel #4186
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,44 +142,41 @@ void ValidateApiCompat (string contractPath, bool validateAgainstReference) | |
| File.Copy (implementationAssembly, Path.Combine (targetImplementationPathDirectory, assemblyToValidate), true); | ||
| } | ||
|
|
||
| for (int i = 0; i < 3; i++) { | ||
|
Contributor
There was a problem hiding this comment. PR #4174 added support to re-execute
Contributor
Author
There was a problem hiding this comment. I wanted to created a new Process object to re-try instead of using the one already created. For some reason I was getting some odd behavior when re-running the process from the same Process object after the crash. When I was reading online, the recommendation was to dispose the object and use a new one. |
||
| using (var genApiProcess = new Process ()) { | ||
|
|
||
| genApiProcess.StartInfo.FileName = apiCompat; | ||
| genApiProcess.StartInfo.Arguments = $"\"{contractPathDirectory}\" -i \"{targetImplementationPathDirectory}\" "; | ||
|
|
||
| // Verify if there is an exclusion list | ||
| var excludeAttributes = Path.Combine (ApiCompatibilityPath, $"api-compat-exclude-attributes.txt"); | ||
| if (File.Exists (excludeAttributes)) { | ||
| genApiProcess.StartInfo.Arguments += $"--exclude-attributes {excludeAttributes} "; | ||
| } | ||
|
|
||
| genApiProcess.StartInfo.UseShellExecute = false; | ||
| genApiProcess.StartInfo.CreateNoWindow = true; | ||
| genApiProcess.StartInfo.RedirectStandardOutput = true; | ||
| genApiProcess.StartInfo.RedirectStandardError = true; | ||
| genApiProcess.EnableRaisingEvents = true; | ||
|
|
||
| var lines = new List<string> (); | ||
| var processHasCrashed = false; | ||
| void dataReceived (object sender, DataReceivedEventArgs args) | ||
| { | ||
| if (!string.IsNullOrWhiteSpace (args.Data)) { | ||
| lines.Add (args.Data.Trim ()); | ||
|
|
||
| if (args.Data.IndexOf ("Native Crash Reporting") != -1) { | ||
| processHasCrashed = true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| genApiProcess.OutputDataReceived += dataReceived; | ||
| genApiProcess.ErrorDataReceived += dataReceived; | ||
|
|
||
| // Get api definition for previous Api | ||
| compatApiCommand = $"CompatApi command: {genApiProcess.StartInfo.FileName} {genApiProcess.StartInfo.Arguments}"; | ||
| Log.LogMessage (MessageImportance.High, compatApiCommand); | ||
|
|
||
|
|
@@ -198,7 +195,8 @@ void dataReceived (object sender, DataReceivedEventArgs args) | |
|
|
||
| if (processHasCrashed) { | ||
| if (i + 1 < 3) { | ||
| Log.LogWarning ($"Process has crashed."); | ||
| Log.LogMessage (MessageImportance.High, String.Join (Environment.NewLine, lines)); | ||
| Log.LogWarning ($"We will retry."); | ||
| continue; | ||
| } else { | ||
|
|
@@ -328,13 +326,15 @@ Dictionary<string, HashSet<string>> LoadIssues (IEnumerable<string> content) | |
| return issues; | ||
| } | ||
|
|
||
| void LogError (string errorMessage) | ||
| { | ||
| var message = string.Empty; | ||
| if (!string.IsNullOrWhiteSpace (compatApiCommand)) { | ||
| errorMessage = $"{compatApiCommand}{Environment.NewLine}{errorMessage}"; | ||
| } | ||
|
|
||
| Log.LogMessage (MessageImportance.High, errorMessage); | ||
| Log.LogError (errorMessage); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason why to bump the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Santi the person responsible and he said they are making some perf improvements, so I decide to bump the version.