Adding api-versions.xml based on the AndroidApiLevel #4186
Conversation
gugavaro
force-pushed
the
gugavaro_sdkdirectory
branch
from
6710960 to
a391bda
Compare
| <PackageReference Include="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.19606.1" IncludeAssets="none" /> | ||
| <PackageReference Include="Microsoft.DotNet.GenAPI" Version="5.0.0-beta.19606.1" /> | ||
| <PackageReference Include="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.20078.1" IncludeAssets="none" /> | ||
| <PackageReference Include="Microsoft.DotNet.GenAPI" Version="5.0.0-beta.20078.1" /> |
There was a problem hiding this comment.
Any specific reason why to bump the version?
There was a problem hiding this comment.
I talked to Santi the person responsible and he said they are making some perf improvements, so I decide to bump the version.
| } | ||
|
|
||
| using (var genApiProcess = new Process ()) { | ||
| for (int i = 0; i < 3; i++) { |
There was a problem hiding this comment.
PR #4174 added support to re-execute Microsoft.DotNet.ApiCompat.exe if/when mono crashes. What are these more recent changes for? I don't see a rationale for these changes within the PR message.
There was a problem hiding this comment.
I wanted to created a new Process object to re-try instead of using the one already created. For some reason I was getting some odd behavior when re-running the process from the same Process object after the crash. When I was reading online, the recommendation was to dispose the object and use a new one.
We currently use api-versions.xml based out of platform-tools\api directory, however it seems this file is not the latest one and also does not contain the ApiLevelSince attribute.
We are now favoring the api-versions.xml out of platforms\android-$(AndroidApiLevel)\data and in case this file does not exist we fall back for the previous location.
On those changes also updating Microsoft.DotNet.ApiCompat to the latest version
Making some small changes on CheckApiCompatibility to better retry and output logs
Updating all acceptable-breakages files