[Xamarin.Android.Build.Tools] Bump android Tools versions. #2835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#2433 We should be using the latest versions of the android tooling if possible. If we can we should try to match the major version with the max API level we support. In this case we are on Android P, API Level 28. So we should be using the 28.x.x versions of the tooling. Since not all of the tools have a 28.x.x version, in those cases we should just use the very latest.
jonathanpeppers
approved these changes
Mar 15, 2019
jonpryor
pushed a commit
that referenced
this pull request
Apr 22, 2019
Fixes: #2433 We should be using the latest versions of the Android tooling if possible, matching the major version with the max API level we support. In this case we are on Android Pie, API-28. Thus we should be using the 28.x.x versions of the tooling. Update `$(AndroidSdkBuildToolsVersion)` to 28.0.3. Update `$(AndroidSdkPlatformToolsVersion)` to 28.0.0. Since not all of the tools have a 28.x.x version, in those cases we should just use the very latest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2433
We should be using the latest versions of the android tooling
if possible. If we can we should try to match the major version
with the max API level we support. In this case we are on Android
P, API Level 28. So we should be using the 28.x.x versions of
the tooling.
Since not all of the tools have a 28.x.x version, in those cases
we should just use the very latest.