Skip to content

Commit c523107

Browse files
dellis1972jonpryor
authored andcommitted
[Xamarin.Android.Build.Tools] Bump Android Tools versions. (#2835)
Fixes: #2433 We should be using the latest versions of the Android tooling if possible, matching the major version with the max API level we support. In this case we are on Android Pie, API-28. Thus we should be using the 28.x.x versions of the tooling. Update `$(AndroidSdkBuildToolsVersion)` to 28.0.3. Update `$(AndroidSdkPlatformToolsVersion)` to 28.0.0. Since not all of the tools have a 28.x.x version, in those cases we should just use the very latest.
1 parent 0fcea30 commit c523107

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

Documentation/workflow/HowToAddNewApiLevel.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,16 @@ Enumification work can be delayed and only the final API has to be enumified.
9393
Note that there are documented and undocumented XML nodes, and we don't have to deal with undocumented ones.
9494

9595
Android P introduced no documented XML artifact.
96+
97+
7) Update Android Tooling Versions
98+
99+
These sre located in [Xamarin.Android.Common.props.in](../../src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.props.in). The following MSBuild properties need to be updated to ensure
100+
the latest tool versions are being used.
101+
102+
`AndroidSdkBuildToolsVersion`
103+
`AndroidSdkPlatformToolsVersion`
104+
`AndroidSdkToolsVersion`
105+
106+
The major version should match the new API level. For Android P this will be 28.x.x . If a version which exactly matches the API Level is not available then the latest version should be used.
107+
108+

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.props.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
<AndroidResourceGeneratorTargetName>UpdateGeneratedFiles</AndroidResourceGeneratorTargetName>
1414
<AndroidUseAapt2 Condition=" '$(AndroidUseAapt2)' == '' ">True</AndroidUseAapt2>
1515
<AndroidUseManagedDesignTimeResourceGenerator Condition=" '$(AndroidUseManagedDesignTimeResourceGenerator)' == '' And '$(OS)' != 'Windows_NT' ">False</AndroidUseManagedDesignTimeResourceGenerator>
16-
<AndroidSdkBuildToolsVersion Condition="'$(AndroidSdkBuildToolsVersion)' == ''">27.0.3</AndroidSdkBuildToolsVersion>
17-
<AndroidSdkPlatformToolsVersion Condition="'$(AndroidSdkPlatformToolsVersion)' == ''">27.0.1</AndroidSdkPlatformToolsVersion>
16+
<AndroidSdkBuildToolsVersion Condition="'$(AndroidSdkBuildToolsVersion)' == ''">28.0.3</AndroidSdkBuildToolsVersion>
17+
<AndroidSdkPlatformToolsVersion Condition="'$(AndroidSdkPlatformToolsVersion)' == ''">28.0.0</AndroidSdkPlatformToolsVersion>
1818
<AndroidSdkToolsVersion Condition="'$(AndroidSdkToolsVersion)' == ''">26.1.1</AndroidSdkToolsVersion>
1919
<AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">16.1</AndroidNdkVersion>
2020
<BundleToolVersion Condition="'$(BundleToolVersion)' == ''">@BUNDLETOOL_VERSION@</BundleToolVersion>

0 commit comments

Comments
 (0)