write the stripped assemblies to new file and then move it

[radekdoulik]

• it looks like with newer mono (or cecil?) we cannot write to the
  opened stream for reading, otherwise we will get sharing violation
  exception
• this should fix part of #44529, other Tasks might need similar
  change

[jonpryor]

This PR should be reviewed and updated after PR #233 is merged.

I suspect that telling DirectoryAssemblyResolver to provide ReaderParameters.InMemory=true within the LinkAssemblies task will actually fix the problem, but that might not be the best solution.

[dellis1972]

@radekdoulik @jonpryor won't this fail if the assembly is readonly. I can't remember if we fix those up before we run this task or not

[jonpryor]

Now that we've merged PR #233, we can tell DirectoryAssemblyResolver to load the assemblies as read/write. Let's see if this works:

diff --git a/src/Xamarin.Android.Build.Tasks/Tasks/StripEmbeddedLibraries.cs b/src/Xamarin.Android.Build.Tasks/Tasks/StripEmbeddedLibraries.cs
index 85f29b8..ed1fa7c 100644
--- a/src/Xamarin.Android.Build.Tasks/Tasks/StripEmbeddedLibraries.cs
+++ b/src/Xamarin.Android.Build.Tasks/Tasks/StripEmbeddedLibraries.cs
@@ -28,7 +28,10 @@ namespace Xamarin.Android.Tasks
            Log.LogDebugMessage ("StripEmbeddedLibraries Task");
            Log.LogDebugTaskItems ("  Assemblies: ", Assemblies);

-           using (var res = new DirectoryAssemblyResolver (Log.LogWarning, true)) {
+           var rp  = new ReaderParameters {
+               ReadWrite   = true,
+           };
+           using (var res = new DirectoryAssemblyResolver (Log.LogWarning, loadDebugSymbols:true, loadReaderParameters:rp)) {
                return Execute (res);
            }
        }
@@ -83,7 +86,7 @@ namespace Xamarin.Android.Tasks
                        WriteSymbols = assembly.MainModule.HasSymbols
                    };

-                   assembly.Write (assemblyPath, wp);
+                   assembly.Write (wp);
                }
            }
            return true;

[jonpryor]

This PR is superseded by PR #239.