[Xamarin.Android.Build.Tasks] make sure Disposable () is called for assembly

[lewurm]

see jbevain/cecil#291

This fixes the Sharing violation issue we've seen in the RemoveRegisterAttribute task. I also attempted to fix #44529.

Depends on dotnet/java-interop#87, then this PR needs an update.

[lewurm]

This supersedes #230. I couldn't repro #44529 specifically though, @radekdoulik could you test it please?

[dellis1972]

Not sure we need a java.interop change, you might need to update your submodules'

[lewurm]

there're changes in Java.Interop required, see dotnet/java-interop#87.

[lewurm]

updated PR, now works with the repro provided by https://bugzilla.xamarin.com/show_bug.cgi?id=44529#c2

However, it's a bit tricky: DirectoryAssemblyResolver caches the results when it loads assemblies, so we need to make sure that we already pass the right ReaderParameters to res.Load (). The ReaderParameters are actually not part of the key in the cache, so they get ignored in res.GetAssembly (). Also, using using for res.GetAssembly () would be wrong (we would dispose it, but there's still a reference to it in the cache).

I think Dispose () of DirectoryAssemblyResolver should dispose all assemblies in its cache or not cache at all (Mono.Cecil.BaseAssemblyResolver doesn't cache either). I'll let someone else decide that.

[jonpryor]

I think Dispose () of DirectoryAssemblyResolver should dispose all assemblies in its cache or not cache at all (Mono.Cecil.BaseAssemblyResolver doesn't cache either).

It should dispose; that is part of dotnet/java-interop#88

[jonpryor]

This PR is superseded by PR #233.