preserve Link action for assemblies #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that they are rewritten with the resolved references - fixes bug #42788 the issue in this bug looks like this: [mscorlib]System.MonoTODOAttribute is referenced from System.Core.dll. because ResolveFromAssemblyStep.ProcessLibrary sets the action to Copy, the System.Core.dll is only copied from original place and not saved with resolved references. the System.MonoTODOAttribute resolves to reference inside the Microsoft.CSharp.dll assembly (where it is kept, it is stripped from mscorlib) and thus the reflection fails at runtime, when tries to load System.Core.dll assembly
Contributor
|
Are you sure this is the case MonoTODOAttribute is internal and we try not to share it |
Member
Author
|
the last part of commit description is actually wrong. the MonoTODO attribute is kept in Microsoft.CSharp.dll just because it had Copy action set as well. after the fix the System.Core doesn't contain references to MonoTODO attribute anymore. this issue is XA specific (XA removes the attribute deliberately while linking), so the mono linker should be OK |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 27, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1314263 Changes: dotnet/android-tools@efc9b67...9b658b2 * dotnet/android-tools@9b658b2: Merge pull request dotnet#133 from xamarin/ndk-r23 * dotnet/android-tools@ff73f92: [build] Use GitInfo to generate $(Version) (dotnet#131) * dotnet/android-tools@4c2e36c: [Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support (dotnet#132) * dotnet/android-tools@eaec4e3: [Xamarin.Android.Tools.AndroidSdk] More Microsoft Dist JDK Support (dotnet#130) * dotnet/android-tools@f9c1b0d: [BaseTasks] improve Task settings in AsyncTaskExtensions (dotnet#129) * dotnet/android-tools@02f7ae7: [NDK] Properly detect 64-bit NDK
jonpryor
added a commit
that referenced
this pull request
Aug 27, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1314263 Changes: dotnet/android-tools@efc9b67...9b658b2 * dotnet/android-tools@9b658b2: Merge pull request #133 from xamarin/ndk-r23 * dotnet/android-tools@ff73f92: [build] Use GitInfo to generate $(Version) (#131) * dotnet/android-tools@4c2e36c: [Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support (#132) * dotnet/android-tools@eaec4e3: [Xamarin.Android.Tools.AndroidSdk] More Microsoft Dist JDK Support (#130) * dotnet/android-tools@f9c1b0d: [BaseTasks] improve Task settings in AsyncTaskExtensions (#129) * dotnet/android-tools@02f7ae7: [NDK] Properly detect 64-bit NDK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that they are rewritten with the resolved references
fixes bug #42788
the issue in this bug looks like this:
[mscorlib]System.MonoTODOAttribute is referenced from
System.Core.dll.
because ResolveFromAssemblyStep.ProcessLibrary sets the action to
Copy, the System.Core.dll is only copied from original place and
not saved with resolved references.
the System.MonoTODOAttribute resolves to reference inside the
Microsoft.CSharp.dll assembly (where it is kept, it is stripped
from mscorlib) and thus the reflection fails at runtime, when tries
to load System.Core.dll assembly