Fix periodic crash on Monodroid appdomain unload #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Designer unloads the Monodroid assembly, mono_java_gc_bridge_info continues pointing to data in the now-invalid assembly image. This currently causes a semi-consistent crash in the Designer tests because the appdomain is unloaded and then reloaded, create_domain (which creates the AppDomain managed object, and therefore implicitly depends on mono_java_gc_bridge_info) is called before init_android_runtime (which populates mono_java_gc_bridge_info with the new data). The solution is to clear mono_java_gc_bridge_info when Monodroid is unloaded. This means all objects will be marked transparent until a new Monodroid is loaded, which is fine because only pure C# objects are being created anyway if Monodroid is unloaded (with one edge case which may still need to be fixed-- see the FIXME comment in this commit).
|
Hi @xmcclure, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Contributor
|
Seems good to me |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 27, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1314263 Changes: dotnet/android-tools@efc9b67...9b658b2 * dotnet/android-tools@9b658b2: Merge pull request dotnet#133 from xamarin/ndk-r23 * dotnet/android-tools@ff73f92: [build] Use GitInfo to generate $(Version) (dotnet#131) * dotnet/android-tools@4c2e36c: [Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support (dotnet#132) * dotnet/android-tools@eaec4e3: [Xamarin.Android.Tools.AndroidSdk] More Microsoft Dist JDK Support (dotnet#130) * dotnet/android-tools@f9c1b0d: [BaseTasks] improve Task settings in AsyncTaskExtensions (dotnet#129) * dotnet/android-tools@02f7ae7: [NDK] Properly detect 64-bit NDK
jonpryor
added a commit
that referenced
this pull request
Aug 27, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1314263 Changes: dotnet/android-tools@efc9b67...9b658b2 * dotnet/android-tools@9b658b2: Merge pull request #133 from xamarin/ndk-r23 * dotnet/android-tools@ff73f92: [build] Use GitInfo to generate $(Version) (#131) * dotnet/android-tools@4c2e36c: [Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support (#132) * dotnet/android-tools@eaec4e3: [Xamarin.Android.Tools.AndroidSdk] More Microsoft Dist JDK Support (#130) * dotnet/android-tools@f9c1b0d: [BaseTasks] improve Task settings in AsyncTaskExtensions (#129) * dotnet/android-tools@02f7ae7: [NDK] Properly detect 64-bit NDK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Designer unloads the Monodroid assembly, mono_java_gc_bridge_info continues pointing to data in the now-invalid assembly image. This currently causes a semi-consistent crash in the Designer tests because the appdomain is unloaded and then reloaded, create_domain (which creates the AppDomain managed object, and therefore implicitly depends on mono_java_gc_bridge_info) is called before init_android_runtime (which populates mono_java_gc_bridge_info with the new data).
The solution is to clear mono_java_gc_bridge_info when Monodroid is unloaded. This means all objects will be marked transparent until a new Monodroid is loaded, which is fine because only pure C# objects are being created anyway if Monodroid is unloaded (with one edge case which may still need to be fixed-- see the FIXME comment in this commit).