Test that JavaTypeSystem makes no changes. #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
test-java-type-system
branch
6 times, most recently
from
244613d to
a7c698f
Compare
jpobst
force-pushed
the
test-java-type-system
branch
from
a7c698f to
834140d
Compare
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Nov 23, 2021
…919) While [testing][0] the new JavaTypeSystem (f658ab2) on [AndroidX][1], the api-diff was reporting various constructors had been removed: ## Xamarin.Android.Glide.dll #### Type Changed: Bumptech.Glide.Registry.NoModelLoaderAvailableException Removed constructor: ```csharp public Registry.NoModelLoaderAvailableException (Java.Lang.Object model, System.Collections.IList matchingButNotHandlingModelLoaders); ``` Investigating let to realizing Java constructors can have generic type parameters: ```java public static class NoModelLoaderAvailableException extends MissingComponentException { public <M> NoModelLoaderAvailableException( @nonnull M model, @nonnull List<ModelLoader<M, ?>> matchingButNotHandlingModelLoaders) { super( "Found ModelLoaders for model class: " + matchingButNotHandlingModelLoaders + ", but none that handle this specific model instance: " + model); } ``` [(source)][2] `class-parse` correctly emits these constructors with generic types: ```xml <constructor deprecated="not deprecated" final="false" name="Registry.NoModelLoaderAvailableException" static="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Ljava/lang/Object;Ljava/util/List;)V"> <typeParameters> <typeParameter name="M" jni-classBound="Ljava/lang/Object;" classBound="java.lang.Object" interfaceBounds="" jni-interfaceBounds="" /> </typeParameters> <parameter name="model" type="M" jni-type="TM;" not-null="true" /> <parameter name="matchingButNotHandlingModelLoaders" type="java.util.List<com.bumptech.glide.load.model.ModelLoader<M, ?>>" jni-type="Ljava/util/List<Lcom/bumptech/glide/load/model/ModelLoader<TM;*>;>;" not-null="true" /> </constructor> ``` We need to import this information in JavaTypeSystem so that the type parameters can be resolved. Without them, the constructor is omitted because the type `M` cannot be resolved: The constructor 'Constructor: com.bumptech.glide.Registry.NoModelLoaderAvailableException.Registry.NoModelLoaderAvailableException' was removed because the Java parameter type 'M' could not be found. Tested against AndroidX and this change restores the constructors. [0]: dotnet/android-libraries#414 [1]: https://github.com/xamarin/AndroidX [2]: https://github.com/bumptech/glide/blob/master/library/src/main/java/com/bumptech/glide/Registry.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Libraries Version (eg: 23.3.0):
Does this change any of the generated binding API's?
Describe your contribution