[JavaTypeSystem] Support importing constructor generic type parameters from class-parse XML files. #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the new JavaTypeSystem on AndroidX, the api-diff was reporting various constructors had been removed:
Xamarin.Android.Glide.dll
Type Changed: Bumptech.Glide.Registry.NoModelLoaderAvailableException
Removed constructor:
Investigating let to realizing Java constructors can have generic type parameters:
(source)
class-parsecorrectly emits these constructor generic types:We need to import this information in JavaTypeSystem so that the type parameters can be resolved. Without them, the constructor is omitted because the type
Mcannot be resolved.Tested against AndroidX and this change restores the constructors.